Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: list supported models #88

Open
pietrushnic opened this issue Dec 31, 2024 · 1 comment
Open

Feature: list supported models #88

pietrushnic opened this issue Dec 31, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@pietrushnic
Copy link
Contributor

It may be helpful to list supported models with some descriptions. Currently, models are hidden behind the scenes in configs, of which the user is unaware. However, as reported in #86, the model can impact how osfv-cli interacts with hardware.

@macpijan macpijan added the good first issue Good for newcomers label Feb 14, 2025
@macpijan
Copy link
Contributor

Models are currently loaded here: https://github.com/Dasharo/osfv-scripts/blob/main/osfv_cli/src/osfv/libs/rte.py#L49C9-L49C24

We can probably propose another file in libs/ that would allow us to get a list of available models and expose this as a new command in CLI.

@macpijan macpijan added this to the v0.6.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants