Skip to content

[ignore me, not merging] WIP hello-world endpoint #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jmthibault79
Copy link
Contributor

Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (b588430) to head (b128004).
Report is 220 commits behind head on develop.

Files with missing lines Patch % Lines
...dsde/workbench/leonardo/http/api/HelloRoutes.scala 25.00% 3 Missing ⚠️
...dinstitute/dsde/workbench/leonardo/http/Boot.scala 0.00% 1 Missing ⚠️
...workbench/leonardo/http/service/HelloService.scala 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4388      +/-   ##
===========================================
- Coverage    73.40%   73.39%   -0.02%     
===========================================
  Files          157      159       +2     
  Lines        14580    14589       +9     
  Branches      1191     1162      -29     
===========================================
+ Hits         10703    10707       +4     
- Misses        3877     3882       +5     
Files with missing lines Coverage Δ
...rkbench/leonardo/http/AppDependenciesBuilder.scala 97.85% <100.00%> (+0.01%) ⬆️
.../dsde/workbench/leonardo/http/api/HttpRoutes.scala 98.43% <100.00%> (+0.05%) ⬆️
...dinstitute/dsde/workbench/leonardo/http/Boot.scala 0.00% <0.00%> (ø)
...workbench/leonardo/http/service/HelloService.scala 0.00% <0.00%> (ø)
...dsde/workbench/leonardo/http/api/HelloRoutes.scala 25.00% <25.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b588430...b128004. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthibault79 jmthibault79 deleted the hello-endpoint branch May 2, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant