RUM-8415 Replace Reflector with ReflectionMirror

Author: mariedm

DatadogInternal/Sources/Utils/ReflectionMirror.swift

@@ -247,7 +247,7 @@ extension ReflectionMirror {
         return descendant(paths: &paths)
     }
 
-    func descendant(_ paths: [Path]) -> Any? {
+    public func descendant(_ paths: [Path]) -> Any? {
         var paths = paths
         return descendant(paths: &paths)
     }

DatadogRUM/Sources/Instrumentation/Views/SwiftUI/SwiftUIViewNameExtractor.swift

@@ -20,23 +20,12 @@ internal struct SwiftUIReflectionBasedViewNameExtractor: SwiftUIViewNameExtracto
 
     init(
         reflectorFactory: @escaping (Any) -> TopLevelReflector = { subject in
-            Reflector(
-                subject: subject,
-                // MARK: TODO: RUM-9035 - Telemetry
-                telemetry: NOPTelemetry()
-            )
+            ReflectionMirror(reflecting: subject)
         }
     ) {
         self.createReflector = reflectorFactory
     }
 
-    /// Convenience initializer
-    init(telemetry: Telemetry) {
-        self.init(reflectorFactory: { subject in
-            Reflector(subject: subject, telemetry: telemetry)
-        })
-    }
-
     /// Attempts to extract a meaningful SwiftUI view name from a `UIViewController`
     /// - Parameter viewController: The `UIViewController` potentially hosting a SwiftUI view
     /// - Returns: The extracted view name or `nil` if extraction failed
@@ -105,11 +94,7 @@ internal struct SwiftUIReflectionBasedViewNameExtractor: SwiftUIViewNameExtracto
 
     // MARK: - Helpers
     private static let genericTypePattern: NSRegularExpression? = {
-        do {
-            return try NSRegularExpression(pattern: #"<(?:[^,>]*,\s+)?([^<>,]+?)>"#)
-        } catch {
-            return nil
-        }
+        return try? NSRegularExpression(pattern: #"<(?:[^,>]*,\s+)?([^<>,]+?)>"#)
     }()
 
     /// Extracts a view name from a type description
@@ -140,7 +125,7 @@ internal struct SwiftUIReflectionBasedViewNameExtractor: SwiftUIViewNameExtracto
         }
 
         let selectedIndex = parent.selectedIndex
-        let containerReflector = Reflector(subject: container, telemetry: NOPTelemetry())
+        let containerReflector = ReflectionMirror(reflecting: container)
 
         if let output = SwiftUIViewPath.hostingController.traverse(with: containerReflector) {
             let typeName = typeDescription(of: output)

DatadogRUM/Sources/Instrumentation/Views/SwiftUI/TopLevelReflector.swift

@@ -16,4 +16,4 @@ internal protocol TopLevelReflector {
 }
 
 // MARK: - Reflector
-extension Reflector: TopLevelReflector {}
+extension ReflectionMirror: TopLevelReflector {}