Dogfood recent changes #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty It also fixes the bug where existing, but inactive view scope was preventing "Background" view from being started. This was corresponding to the scenario when an app is sent to background while a resource is being loaded - until the resource finished, no "Background" view could be started.
this is to capture "app launch" events before starting first view.
with ensuring that only one listener is created for the entire SDK.
by ensuring that app starts "ApplicationLaunch" view only if launched in foreground and it starts "Background" view when launched in background with "Background Events Tracking" option enabled.
…a very first event in the view
… foreground / background state so it can be accessed in restarted session, when deciding on how to upload crash report.
so it can be used both in RUM and Crash Reporting for sampling session and/or crash report.
…application-launch-view-when-app-in-background RUMM-1765 Do not start "ApplicationLaunch" view when app launches in background - part 2
…andler-memory-leak RUMM-1839 Fix Application Launch Handler Memory Leak
…cation RUMM-1805 Set `PLCrashReporter` custom path
…aunch-crashes RUMM-1765 Update `CrashContext` with necessary info for handling App Launch crashes - part 3
…ssion while there was no Background view started.
…ode-to-SDK RUMM-1744 Copy Kronos code to SDK
so it can be monitored in nightly runs.
…nos-tests RUMM-1744 Add E2E tests for Kronos (NTP)
RUMM-1779 Keep view active until all resources are consumed
to simplify assertion of GH asset content
…e-tool-to-conditionally-include-Kronos RUMM-1744 Update release tool to conditionally validate `Kronos.xcframework`
…directly-into-SDK RUMM-1744 Embed Kronos directly into SDK (combined merge)
…spm-doc RUMM-1799 Clarify Linking Crash Reporting Using SPM
notably: `testWhenDataIsBeingUploaded_itPrintsUploadProgressInformationAndSendsErrorsThroughInternalMonitoring` The flakiness was caused by `userLogger` reference leaked in some other tests which use `DateCorrector` (e.g. all tests in `DatadogTests`). NTP sync completion block was executed no matter of `self` existence, making it send logs to current (global) `userLogger` arbitrarily. This was causing some other tests asserting `userLogger` output to receive false data, coming not from their execution.
by running each measure to fixed number of samples, instead of using time-based condition.
precisely in `testWhenCurrentValueIsObtainedFromNetworkConnectionInfoProvider_thenCrashContextProviderNotifiesNewContext`.
by ensuring autorelease VC deallocation with `autoreleasepool {}`
…ntsAreSent` by increasing number of samples to 400 (with 200 it was failing 4/500 repetitions, with 300 1/500, with 400 it's 100% success).
…om-nightly-tests RUMM-1890 Fix tests flakiness
…s-telemetry-in-internal-monitoring RUMM-1744 Collect Kronos telemetry in Internal Monitoring
buranmert
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🐶 Dogfooding recent changes, notably:
Lesser impact:
PLCrashReportercustom path #692How?
master→dogfoodingReview checklist