-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computes cutoff/threshold once in DeterministicSampler. #8395
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041493
Total [baseline] (10.451 s) : 0, 10451108
Agent [candidate] (1.042 s) : 0, 1042440
Total [candidate] (10.526 s) : 0, 10525780
section appsec
Agent [baseline] (1.188 s) : 0, 1188411
Total [baseline] (10.814 s) : 0, 10814032
Agent [candidate] (1.189 s) : 0, 1188975
Total [candidate] (10.744 s) : 0, 10743668
section iast
Agent [baseline] (1.183 s) : 0, 1183166
Total [baseline] (11.011 s) : 0, 11011070
Agent [candidate] (1.172 s) : 0, 1172171
Total [candidate] (11.011 s) : 0, 11010938
section profiling
Agent [baseline] (1.263 s) : 0, 1263022
Total [baseline] (10.908 s) : 0, 10907722
Agent [candidate] (1.261 s) : 0, 1260952
Total [candidate] (10.834 s) : 0, 10833855
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.251 ms) : 0, 718251
BytebuddyAgent [candidate] (718.268 ms) : 0, 718268
GlobalTracer [baseline] (239.887 ms) : 0, 239887
GlobalTracer [candidate] (241.526 ms) : 0, 241526
AppSec [baseline] (55.321 ms) : 0, 55321
AppSec [candidate] (55.387 ms) : 0, 55387
Remote Config [baseline] (690.944 µs) : 0, 691
Remote Config [candidate] (701.66 µs) : 0, 702
Telemetry [baseline] (12.054 ms) : 0, 12054
Telemetry [candidate] (11.311 ms) : 0, 11311
section appsec
BytebuddyAgent [baseline] (738.868 ms) : 0, 738868
BytebuddyAgent [candidate] (738.822 ms) : 0, 738822
GlobalTracer [baseline] (237.326 ms) : 0, 237326
GlobalTracer [candidate] (237.83 ms) : 0, 237830
AppSec [baseline] (177.135 ms) : 0, 177135
AppSec [candidate] (177.318 ms) : 0, 177318
Remote Config [baseline] (676.794 µs) : 0, 677
Remote Config [candidate] (678.477 µs) : 0, 678
Telemetry [baseline] (8.34 ms) : 0, 8340
Telemetry [candidate] (8.267 ms) : 0, 8267
IAST [baseline] (21.49 ms) : 0, 21490
IAST [candidate] (21.447 ms) : 0, 21447
section iast
BytebuddyAgent [baseline] (843.519 ms) : 0, 843519
BytebuddyAgent [candidate] (835.915 ms) : 0, 835915
GlobalTracer [baseline] (233.083 ms) : 0, 233083
GlobalTracer [candidate] (231.062 ms) : 0, 231062
AppSec [baseline] (58.305 ms) : 0, 58305
AppSec [candidate] (57.587 ms) : 0, 57587
Remote Config [baseline] (641.846 µs) : 0, 642
Remote Config [candidate] (623.83 µs) : 0, 624
Telemetry [baseline] (8.823 ms) : 0, 8823
Telemetry [candidate] (8.734 ms) : 0, 8734
IAST [baseline] (23.165 ms) : 0, 23165
IAST [candidate] (22.884 ms) : 0, 22884
section profiling
BytebuddyAgent [baseline] (708.793 ms) : 0, 708793
BytebuddyAgent [candidate] (707.648 ms) : 0, 707648
GlobalTracer [baseline] (350.69 ms) : 0, 350690
GlobalTracer [candidate] (350.693 ms) : 0, 350693
AppSec [baseline] (55.207 ms) : 0, 55207
AppSec [candidate] (54.857 ms) : 0, 54857
Remote Config [baseline] (681.164 µs) : 0, 681
Remote Config [candidate] (677.251 µs) : 0, 677
Telemetry [baseline] (8.951 ms) : 0, 8951
Telemetry [candidate] (8.927 ms) : 0, 8927
ProfilingAgent [baseline] (96.277 ms) : 0, 96277
ProfilingAgent [candidate] (95.722 ms) : 0, 95722
Profiling [baseline] (96.301 ms) : 0, 96301
Profiling [candidate] (95.747 ms) : 0, 95747
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044590
Total [baseline] (8.645 s) : 0, 8645103
Agent [candidate] (1.044 s) : 0, 1043980
Total [candidate] (8.645 s) : 0, 8645329
section iast
Agent [baseline] (1.171 s) : 0, 1171281
Total [baseline] (9.261 s) : 0, 9260874
Agent [candidate] (1.179 s) : 0, 1179311
Total [candidate] (9.259 s) : 0, 9259252
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1169220
Total [baseline] (9.234 s) : 0, 9234220
Agent [candidate] (1.173 s) : 0, 1172868
Total [candidate] (9.28 s) : 0, 9280070
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174806
Total [baseline] (9.257 s) : 0, 9257028
Agent [candidate] (1.171 s) : 0, 1171361
Total [candidate] (9.271 s) : 0, 9271222
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.437 ms) : 0, 719437
BytebuddyAgent [candidate] (719.429 ms) : 0, 719429
GlobalTracer [baseline] (240.807 ms) : 0, 240807
GlobalTracer [candidate] (240.403 ms) : 0, 240403
AppSec [baseline] (55.96 ms) : 0, 55960
AppSec [candidate] (55.44 ms) : 0, 55440
Remote Config [baseline] (713.004 µs) : 0, 713
Remote Config [candidate] (700.991 µs) : 0, 701
Telemetry [baseline] (12.423 ms) : 0, 12423
Telemetry [candidate] (12.839 ms) : 0, 12839
section iast
BytebuddyAgent [baseline] (836.101 ms) : 0, 836101
BytebuddyAgent [candidate] (842.162 ms) : 0, 842162
GlobalTracer [baseline] (230.271 ms) : 0, 230271
GlobalTracer [candidate] (232.035 ms) : 0, 232035
AppSec [baseline] (57.353 ms) : 0, 57353
AppSec [candidate] (57.267 ms) : 0, 57267
Remote Config [baseline] (634.258 µs) : 0, 634
Remote Config [candidate] (649.138 µs) : 0, 649
Telemetry [baseline] (8.747 ms) : 0, 8747
Telemetry [candidate] (8.806 ms) : 0, 8806
IAST [baseline] (22.922 ms) : 0, 22922
IAST [candidate] (23.059 ms) : 0, 23059
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.797 ms) : 0, 834797
BytebuddyAgent [candidate] (837.401 ms) : 0, 837401
GlobalTracer [baseline] (229.789 ms) : 0, 229789
GlobalTracer [candidate] (231.231 ms) : 0, 231231
AppSec [baseline] (57.153 ms) : 0, 57153
AppSec [candidate] (57.077 ms) : 0, 57077
Remote Config [baseline] (628.83 µs) : 0, 629
Remote Config [candidate] (613.579 µs) : 0, 614
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (8.611 ms) : 0, 8611
IAST [baseline] (22.898 ms) : 0, 22898
IAST [candidate] (22.637 ms) : 0, 22637
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.838 ms) : 0, 839838
BytebuddyAgent [candidate] (835.762 ms) : 0, 835762
GlobalTracer [baseline] (231.248 ms) : 0, 231248
GlobalTracer [candidate] (231.738 ms) : 0, 231738
AppSec [baseline] (54.664 ms) : 0, 54664
AppSec [candidate] (51.556 ms) : 0, 51556
Remote Config [baseline] (613.519 µs) : 0, 614
Remote Config [candidate] (619.02 µs) : 0, 619
Telemetry [baseline] (8.542 ms) : 0, 8542
Telemetry [candidate] (8.618 ms) : 0, 8618
IAST [baseline] (24.5 ms) : 0, 24500
IAST [candidate] (27.719 ms) : 0, 27719
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section baseline
no_agent (1.369 ms) : 1348, 1390
. : milestone, 1369,
appsec (1.756 ms) : 1733, 1779
. : milestone, 1756,
appsec_no_iast (1.753 ms) : 1730, 1777
. : milestone, 1753,
iast (1.503 ms) : 1479, 1527
. : milestone, 1503,
profiling (1.518 ms) : 1493, 1543
. : milestone, 1518,
tracing (1.513 ms) : 1489, 1537
. : milestone, 1513,
section candidate
no_agent (1.361 ms) : 1341, 1381
. : milestone, 1361,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.76 ms) : 1736, 1784
. : milestone, 1760,
iast (1.512 ms) : 1489, 1536
. : milestone, 1512,
profiling (1.519 ms) : 1494, 1544
. : milestone, 1519,
tracing (1.492 ms) : 1466, 1518
. : milestone, 1492,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section baseline
no_agent (385.849 µs) : 366, 405
. : milestone, 386,
iast (512.557 µs) : 490, 535
. : milestone, 513,
iast_FULL (744.836 µs) : 723, 767
. : milestone, 745,
iast_GLOBAL (561.541 µs) : 539, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (511.263 µs) : 489, 533
. : milestone, 511,
iast_INACTIVE (457.736 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (494.939 µs) : 473, 517
. : milestone, 495,
tracing (452.728 µs) : 429, 476
. : milestone, 453,
section candidate
no_agent (381.241 µs) : 361, 401
. : milestone, 381,
iast (512.063 µs) : 489, 535
. : milestone, 512,
iast_FULL (743.011 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (556.057 µs) : 534, 578
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (505.717 µs) : 484, 527
. : milestone, 506,
iast_INACTIVE (467.447 µs) : 446, 489
. : milestone, 467,
iast_TELEMETRY_OFF (498.92 µs) : 477, 521
. : milestone, 499,
tracing (451.351 µs) : 431, 472
. : milestone, 451,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.34 ms) : 2298, 2383
. : milestone, 2340,
iast (2.11 ms) : 2055, 2165
. : milestone, 2110,
iast_GLOBAL (2.152 ms) : 2097, 2207
. : milestone, 2152,
profiling (1.978 ms) : 1934, 2023
. : milestone, 1978,
tracing (1.942 ms) : 1900, 1985
. : milestone, 1942,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.346 ms) : 2303, 2389
. : milestone, 2346,
iast (2.105 ms) : 2050, 2160
. : milestone, 2105,
iast_GLOBAL (2.151 ms) : 2096, 2206
. : milestone, 2151,
profiling (1.991 ms) : 1947, 2036
. : milestone, 1991,
tracing (1.941 ms) : 1899, 1984
. : milestone, 1941,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~1794e213f1, baseline=1.47.0-SNAPSHOT~bab17eff8d
dateFormat X
axisFormat %s
section baseline
no_agent (15.611 s) : 15611000, 15611000
. : milestone, 15611000,
appsec (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
iast (18.398 s) : 18398000, 18398000
. : milestone, 18398000,
iast_GLOBAL (18.181 s) : 18181000, 18181000
. : milestone, 18181000,
profiling (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
tracing (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
section candidate
no_agent (15.225 s) : 15225000, 15225000
. : milestone, 15225000,
appsec (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
iast (18.525 s) : 18525000, 18525000
. : milestone, 18525000,
iast_GLOBAL (17.591 s) : 17591000, 17591000
. : milestone, 17591000,
profiling (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
tracing (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
|
What Does This Do
Computes cutoff/threshold of the DeterministicSampler only once in constructor.
Motivation
More efficient.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]