WIP: SQLServer XE handlers documentation #29291
Conversation
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
azhou-datadog
changed the title
|
Hi @azhou-datadog, I see this is labeled as a WIP. I went ahead and added the |
| ); | ||
| GO | ||
|
|
||
| -- 2. Errors and Attentions (grouped) |
There was a problem hiding this comment.
Would it make sense to split the 2 sessions into 2 separate code blocks? Or at least mentioning the 2 different session types outside the code block (since they are mentioned on line 190)
| **Performance Considerations** | ||
| - Extended Events are designed to be lightweight but still have some overhead | ||
| - If you observe performance issues, consider: | ||
| - Increasing duration thresholds |
There was a problem hiding this comment.
I think linking back up the page to how to do this would be good
| - Extended Events are designed to be lightweight but still have some overhead | ||
| - If you observe performance issues, consider: | ||
| - Increasing duration thresholds | ||
| - Adding more specific filters |
There was a problem hiding this comment.
similar to my previous comment
| - If you observe performance issues, consider: | ||
| - Increasing duration thresholds | ||
| - Adding more specific filters | ||
| - Disabling one or both sessions during peak load periods |
There was a problem hiding this comment.
naming the sessions or being able to explicit how to would be great IMO
| ); | ||
| GO | ||
|
|
||
| -- 2. Errors and Attentions (grouped) |
There was a problem hiding this comment.
Same comment as for the default SQL Server (if splitting makes sense)
|
|
||
| ## Exploring deobfuscated queries | ||
|
|
||
| Workflow is still a work in progress. |
There was a problem hiding this comment.
Is this expected to be released with this? Or will the docs be updated to reflect the actual workflow? Because if the workflow is indeed a WIP by the time the docs are released, I think we need a different way to phrase this
There was a problem hiding this comment.
definitely not releasing with this, this is more of a TODO for myself :)
What does this PR do? What is the motivation?
Adds documentation to support DataDog/integrations-core#20229
Provides instructions on how to configure SQLServer extended event (XE) sessions to capture query errors and query completions.
Merge instructions
WIP: This docs update should not be merged until the backend and front end components are complete. Only the integration-core changes are written so far.
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes