Refactor to use Dependency structure #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikretz
requested changes
May 12, 2025
ikretz
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Historically guarddog uses dicts as DTOs for several purposes, one major problem is that they are passed from function to nested functions and that combined with the lack of proper OOP produces lots of runtime errors, since each function assumes a different data structure.
This approach also makes it very complex to enhance or change the structure without a major impact.
Solution:
This PR replaces the use of a dictionary with a structured
@dataclassobject for dependencies forcing functions to standardize and respect the type check.Fixes: #558
Fixes: #261