Stop relying on manifest.json to validate spec.yaml

Author: iliakur

datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/config.py

@@ -12,6 +12,7 @@
 from ...config_validator.validator_errors import SEVERITY_ERROR, SEVERITY_WARNING
 from ...configuration import ConfigSpec
 from ...configuration.consumers import ExampleConsumer
+from ...constants import get_root
 from ...manifest_utils import Manifest
 from ...testing import process_checks_option
 from ...utils import complete_valid_checks, get_config_files, get_data_directory, get_version_string
@@ -67,7 +68,7 @@ def config(ctx, check, sync, verbose):
             echo_debug(f"Skipping validation for check: {check}; can't process manifest")
             continue
 
-        spec_file_path = manifest.get_config_spec()
+        spec_file_path = path_join(get_root(), check, 'assets', 'configuration', 'spec.yaml')
         if not file_exists(spec_file_path):
             example_location = get_data_directory(check)
 

datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/models.py

@@ -16,7 +16,6 @@
 from ...configuration import ConfigSpec
 from ...configuration.consumers import ModelConsumer
 from ...constants import get_root
-from ...manifest_utils import Manifest
 from ...testing import process_checks_option
 from ...utils import (
     CUSTOM_FILES,
@@ -31,7 +30,6 @@
     abort,
     annotate_display_queue,
     annotate_error,
-    echo_debug,
     echo_failure,
     echo_info,
     echo_success,
@@ -108,11 +106,7 @@ def models(ctx, check, sync, verbose):
             source = 'test'
             version = '0.0.1'
         else:
-            manifest = Manifest.load_manifest(check)
-            if not manifest:
-                echo_debug(f"Skipping validation for check: {check}; can't process manifest")
-                continue
-            spec_path = manifest.get_config_spec()
+            spec_path = path_join(root, check, 'assets', 'configuration', 'spec.yaml')
             if not file_exists(spec_path):
                 continue
 

datadog_checks_dev/datadog_checks/dev/tooling/configuration/spec.py

@@ -10,15 +10,6 @@ def spec_validator(spec: dict, loader) -> None:
         loader.errors.append(f'{loader.source}: Configuration specifications must be a mapping object')
         return
 
-    if 'name' not in spec:
-        loader.errors.append(f'{loader.source}: Configuration specifications must contain a top-level `name` attribute')
-        return
-
-    name = spec['name']
-    if not isinstance(name, str):
-        loader.errors.append(f'{loader.source}: The top-level `name` attribute must be a string')
-        return
-
     release_version = spec.setdefault('version', loader.version)
     if not release_version:
         loader.errors.append(