Use a forced metric type of gauge for ccmRejectedPhones and ccmUnregisteredPhones. (#17722) (#17751)

* Use a forced metric type of gauge for ccmRejectedPhones and ccmUnregisteredPhones.

* Fix test_cisco_voice profile test.

* Add changelog.

(cherry picked from commit ff2f2d0)

Co-authored-by: Jim Wilson <86026167+jmw51798@users.noreply.github.com>

Author: datadog-agent-integrations-bot[bot]

snmp/changelog.d/17722.fixed

@@ -0,0 +1 @@
+Use a forced metric type of gauge for ccmRejectedPhones and ccmUnregisteredPhones so they are not incorrectly inferred to be rate types.

snmp/datadog_checks/snmp/data/default_profiles/_cisco-voice.yaml

@@ -74,10 +74,12 @@ metrics:
       name: ccmRegisteredPhones
       OID: 1.3.6.1.4.1.9.9.156.1.5.5.0
   - MIB: CISCO-CCM-MIB
+    metric_type: gauge
     symbol:
       name: ccmRejectedPhones
       OID: 1.3.6.1.4.1.9.9.156.1.5.7.0
   - MIB: CISCO-CCM-MIB
+    metric_type: gauge
     symbol:
       name: ccmUnregisteredPhones
       OID: 1.3.6.1.4.1.9.9.156.1.5.6.0

snmp/tests/test_profiles.py

@@ -182,12 +182,7 @@ def test_cisco_voice(aggregator):
     for cvp in cvp_gauges:
         aggregator.assert_metric('snmp.{}'.format(cvp), metric_type=aggregator.GAUGE, tags=tags)
 
-    ccms_counts = ["ccmRejectedPhones", "ccmUnregisteredPhones"]
-
-    ccms_gauges = ["ccmRegisteredGateways", "ccmRegisteredPhones"]
-
-    for ccm in ccms_counts:
-        aggregator.assert_metric('snmp.{}'.format(ccm), metric_type=aggregator.RATE, tags=tags)
+    ccms_gauges = ["ccmRegisteredGateways", "ccmRegisteredPhones", "ccmRejectedPhones", "ccmUnregisteredPhones"]
 
     for ccm in ccms_gauges:
         aggregator.assert_metric('snmp.{}'.format(ccm), metric_type=aggregator.GAUGE, tags=tags)