Fix sqlserver metric collection row_key (#18882)

joelmarcotte · web-flow · commit 2b35698dcdf8 · 2024-10-23T18:08:15.000Z
* Fix sqlserver metric collection row_key

* changelog

* lint
diff --git a/sqlserver/changelog.d/18882.fixed b/sqlserver/changelog.d/18882.fixed
@@ -0,0 +1 @@
+Update sqlserver metric collection row_key to prevent overwriting metric information for two queries with the same query_plan_hash but part of two different stored procedures.
diff --git a/sqlserver/datadog_checks/sqlserver/statements.py b/sqlserver/datadog_checks/sqlserver/statements.py
@@ -153,12 +153,7 @@ def _row_key(row):
     :param row: a normalized row from STATEMENT_METRICS_QUERY
     :return: a tuple uniquely identifying this row
     """
-    return (
-        row.get('database_name'),
-        row['query_signature'],
-        row['query_hash'],
-        row['query_plan_hash'],
-    )
+    return (row.get('database_name'), row['query_signature'], row['query_hash'], row.get('procedure_name'))
 
 
 XML_PLAN_OBFUSCATION_ATTRS = frozenset(

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Update sqlserver metric collection row_key to prevent overwriting metric information for two queries with the same query_plan_hash but part of two different stored procedures.`