Skip to content

Commit 4410663

Browse files
committed
Update config models
1 parent 44c7e8a commit 4410663

File tree

4 files changed

+16
-9
lines changed

4 files changed

+16
-9
lines changed

postgres/datadog_checks/postgres/config_models/defaults.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,3 +138,7 @@ def instance_table_count_limit():
138138

139139
def instance_tag_replication_role():
140140
return False
141+
142+
143+
def instance_use_global_custom_queries():
144+
return 'extend'

postgres/datadog_checks/postgres/config_models/instance.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class ManagedAuthentication(BaseModel):
2525
arbitrary_types_allowed=True,
2626
frozen=True,
2727
)
28-
enabled: Optional[bool] = Field(None, examples=[False])
28+
enabled: Optional[bool] = Field(None, example=False)
2929

3030

3131
class Aws(BaseModel):
@@ -44,8 +44,8 @@ class ManagedAuthentication1(BaseModel):
4444
frozen=True,
4545
)
4646
client_id: Optional[str] = None
47-
enabled: Optional[bool] = Field(None, examples=[False])
48-
identity_scope: Optional[str] = Field(None, examples=['https://ossrdbms-aad.database.windows.net/.default'])
47+
enabled: Optional[bool] = Field(None, example=False)
48+
identity_scope: Optional[str] = Field(None, example='https://ossrdbms-aad.database.windows.net/.default')
4949

5050

5151
class Azure(BaseModel):
@@ -176,7 +176,7 @@ class QuerySamples(BaseModel):
176176
seen_samples_cache_maxsize: Optional[int] = None
177177

178178

179-
class Relations(BaseModel):
179+
class Relation(BaseModel):
180180
model_config = ConfigDict(
181181
arbitrary_types_allowed=True,
182182
frozen=True,
@@ -238,7 +238,7 @@ class InstanceConfig(BaseModel):
238238
query_metrics: Optional[QueryMetrics] = None
239239
query_samples: Optional[QuerySamples] = None
240240
query_timeout: Optional[int] = None
241-
relations: Optional[tuple[Union[str, Relations], ...]] = None
241+
relations: Optional[tuple[Union[str, Relation], ...]] = None
242242
reported_hostname: Optional[str] = None
243243
service: Optional[str] = None
244244
ssl: Optional[str] = None
@@ -249,6 +249,7 @@ class InstanceConfig(BaseModel):
249249
table_count_limit: Optional[int] = None
250250
tag_replication_role: Optional[bool] = None
251251
tags: Optional[tuple[str, ...]] = None
252+
use_global_custom_queries: Optional[str] = None
252253
username: str
253254

254255
@model_validator(mode='before')

postgres/datadog_checks/postgres/config_models/shared.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99

1010
from __future__ import annotations
1111

12-
from typing import Optional
12+
from types import MappingProxyType
13+
from typing import Any, Optional
1314

1415
from pydantic import BaseModel, ConfigDict, field_validator, model_validator
1516

@@ -25,6 +26,7 @@ class SharedConfig(BaseModel):
2526
arbitrary_types_allowed=True,
2627
frozen=True,
2728
)
29+
global_custom_queries: Optional[tuple[MappingProxyType[str, Any], ...]] = None
2830
propagate_agent_tags: Optional[bool] = None
2931
service: Optional[str] = None
3032

postgres/tests/test_custom_metrics.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def test_only_global_custom_queries(aggregator, pg_instance):
119119
'tags': ['query:custom'],
120120
},
121121
],
122-
'use_global_custom_queries': 'true'
122+
'use_global_custom_queries': 'true',
123123
}
124124
)
125125
pg_init_config = {
@@ -158,7 +158,7 @@ def test_only_instance_custom_queries(aggregator, pg_instance):
158158
'tags': ['query:custom'],
159159
},
160160
],
161-
'use_global_custom_queries': 'false'
161+
'use_global_custom_queries': 'false',
162162
}
163163
)
164164
pg_init_config = {
@@ -181,4 +181,4 @@ def test_only_instance_custom_queries(aggregator, pg_instance):
181181
custom_tags.extend(tags)
182182

183183
aggregator.assert_metric('custom.num', value=value, tags=custom_tags + ['query:custom'])
184-
aggregator.assert_metric('global_custom.num', value=value, tags=custom_tags + ['query:global_custom'], count=0)
184+
aggregator.assert_metric('global_custom.num', value=value, tags=custom_tags + ['query:global_custom'], count=0)

0 commit comments

Comments
 (0)