Skip to content

Commit 48c8722

Browse files
authored
Update singlestore image and version used in CI (#20207)
* update image * fix * test * update expected version * add condition back * add comment
1 parent d49988b commit 48c8722

File tree

6 files changed

+10
-24
lines changed

6 files changed

+10
-24
lines changed

.ddev/ci/scripts/singlestore/linux/55_set_license_secret.sh

Lines changed: 0 additions & 8 deletions
This file was deleted.

.github/workflows/test-fips-e2e.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ jobs:
9898
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN_2 }}
9999
ORACLE_DOCKER_USERNAME: ${{ secrets.ORACLE_DOCKER_USERNAME }}
100100
ORACLE_DOCKER_PASSWORD: ${{ secrets.ORACLE_DOCKER_PASSWORD_2 }}
101-
SINGLESTORE_LICENSE: ${{ secrets.SINGLESTORE_LICENSE_2 }}
102101
DD_GITHUB_USER: ${{ github.actor }}
103102
DD_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
104103
run: ddev ci setup ${{ inputs.target || 'tls' }}

.github/workflows/test-target.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,13 @@ jobs:
199199
"DOCKER_ACCESS_TOKEN": "{1}",
200200
"ORACLE_DOCKER_USERNAME": "{2}",
201201
"ORACLE_DOCKER_PASSWORD": "{3}",
202-
"SINGLESTORE_LICENSE": "{4}",
203-
"DD_GITHUB_USER": "{5}",
204-
"DD_GITHUB_TOKEN": "{6}"
202+
"DD_GITHUB_USER": "{4}",
203+
"DD_GITHUB_TOKEN": "{5}"
205204
}}',
206205
secrets.DOCKER_USERNAME_2,
207206
secrets.DOCKER_ACCESS_TOKEN_2,
208207
secrets.ORACLE_DOCKER_USERNAME,
209208
secrets.ORACLE_DOCKER_PASSWORD_2,
210-
secrets.SINGLESTORE_LICENSE_2,
211209
github.actor,
212210
secrets.GITHUB_TOKEN
213211
))}}
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
services:
22
singlestore:
3-
image: 'singlestore/cluster-in-a-box:centos-7.5.9-a8744b5453-3.2.11-1.12.1'
3+
image: ghcr.io/singlestore-labs/singlestoredb-dev:0.2.51
44
ports:
55
- 3306:3306
66
- 8080:8080
7+
# follow these steps if running on m1: https://github.com/singlestore-labs/singlestoredb-dev-image?tab=readme-ov-file#how-to-run-the-docker-image-on-apple-silicon-m1m2-chips
8+
platform: linux/amd64
79
environment:
8-
LICENSE_KEY: ${LICENSE_KEY}
910
ROOT_PASSWORD: 'password'
1011
START_AFTER_INIT: 'Y'

singlestore/tests/conftest.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,7 @@ def _mock_execute(query):
2727
@pytest.fixture(scope='session')
2828
def dd_environment():
2929
compose_file = os.path.join(HERE, 'compose', 'docker-compose.yaml')
30-
license_key = os.environ.get('SINGLESTORE_LICENSE')
31-
if not license_key:
32-
raise Exception("Please set SINGLESTORE_LICENSE environment variable to a valid base64-encoded license.")
33-
34-
with docker_run(compose_file, env_vars={'LICENSE_KEY': license_key}, log_patterns=r'Listening on 0\.0\.0\.0'):
30+
with docker_run(compose_file, log_patterns=r'Listening on 0\.0\.0\.0.'):
3531
yield {
3632
'host': get_docker_hostname(),
3733
'username': 'root',

singlestore/tests/test_integration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ def test_integration(dd_environment, dd_run_check, datadog_agent, aggregator):
1414
aggregator.assert_all_metrics_covered()
1515
version_metadata = {
1616
'version.scheme': 'semver',
17-
'version.major': '7',
18-
'version.minor': '5',
19-
'version.patch': '9',
20-
'version.raw': '7.5.9',
17+
'version.major': '8',
18+
'version.minor': '9',
19+
'version.patch': '19',
20+
'version.raw': '8.9.19',
2121
}
2222
datadog_agent.assert_metadata('', version_metadata)
2323
aggregator.assert_service_check(

0 commit comments

Comments
 (0)