move exception to test to unit tests

Author: NouemanKHAL

teleport/datadog_checks/teleport/check.py

@@ -33,12 +33,5 @@ def check(self, _):
 
     def _parse_config(self):
         if self.diagnostic_url:
-            self.instance.setdefault("openmetrics_endpoint", self.diagnostic_url+"/metrics")
-
-        # if diagnostic_url:
-        #     # We create another config to scrape Gitaly metrics, so we have two different scrapers:
-        #     # one for the main GitLab and another one for the Gitaly endpoint.
-        #     config = copy.deepcopy(self.instance)
-        #     config['openmetrics_endpoint'] = diagnostic_url + "/metrics"
-        #     config['namespace'] = 'teleport'
-        #     self.scraper_configs.append(config)
+            self.instance.setdefault("openmetrics_endpoint", self.diagnostic_url + "/metrics")
+            self.instance.setdefault("metrics", ["process_state"])

teleport/tests/test_integration.py

@@ -9,11 +9,6 @@
 
 pytestmark = [pytest.mark.integration, pytest.mark.usefixtures('dd_environment')]
 
-def test_connect_exception(aggregator, dd_run_check):
-    instance = {"diagnostic_url": "https://wrong_endpoint/metrics"}
-    check = TeleportCheck('teleport', {}, [instance])
-    dd_run_check(check)
-    aggregator.assert_service_check('teleport.health.up', status=AgentCheck.CRITICAL)
 
 def test_connect_ok(aggregator, dd_run_check):
     instance = {"diagnostic_url": "http://127.0.0.1:3000"}
@@ -22,6 +17,7 @@ def test_connect_ok(aggregator, dd_run_check):
     aggregator.assert_service_check('teleport.health.up', status=AgentCheck.OK, count=1)
     aggregator.assert_service_check('teleport.health.up', status=AgentCheck.CRITICAL, count=0)
 
+
 def test_check_collects_teleport_common_metrics(aggregator, dd_run_check):
     instance = {"diagnostic_url": "http://127.0.0.1:3000"}
     check = TeleportCheck('teleport', {}, [instance])
@@ -39,4 +35,4 @@ def test_check_collects_teleport_common_metrics(aggregator, dd_run_check):
     ]
 
     for metric in common_metrics:
-        aggregator.assert_metric(f"teleport.{metric}", tags=None, count=1)
+        aggregator.assert_metric(f"teleport.{metric}", tags=None, count=1)

teleport/tests/test_unit.py

@@ -0,0 +1,16 @@
+# (C) Datadog, Inc. 2024-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+import pytest
+
+from datadog_checks.teleport import TeleportCheck
+
+pytestmark = [pytest.mark.unit]
+
+
+def test_connect_exception(dd_run_check):
+    instance = {}
+    check = TeleportCheck('teleport', {}, [instance])
+    with pytest.raises(Exception):
+        dd_run_check(check)