Skip to content

Commit 75c83a8

Browse files
Rename velero.backup and velero.restore metrics (#19904) (#19905)
* Rename backup and restore metrics * Add changelog (cherry picked from commit 6f3ab90) Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>
1 parent db4697a commit 75c83a8

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

velero/changelog.d/19904.changed

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Rename `velero.backup` and `velero.restore` metrics

velero/datadog_checks/velero/metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
'velero_backup_partial_failure': 'backup.partial_failure',
2727
'velero_backup_success': 'backup.success',
2828
'velero_backup_tarball_size_bytes': 'backup.tarball_size_bytes',
29-
'velero_backup_total': 'backup',
29+
'velero_backup_total': 'backup.amount',
3030
'velero_backup_validation_failure': 'backup.validation_failure',
3131
'velero_backup_warning': 'backup.warning',
3232
'velero_csi_snapshot_attempt': 'csi_snapshot.attempt',
@@ -36,7 +36,7 @@
3636
'velero_restore_failed': 'restore.failed',
3737
'velero_restore_partial_failure': 'restore.partial_failure',
3838
'velero_restore_success': 'restore.success',
39-
'velero_restore_total': 'restore',
39+
'velero_restore_total': 'restore.amount',
4040
'velero_restore_validation_failed': 'restore.validation_failed',
4141
'velero_volume_snapshot_attempt': 'volume_snapshot.attempt',
4242
'velero_volume_snapshot_failure': 'volume_snapshot.failure',

velero/metadata.csv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric,sample_tags
2-
velero.backup,gauge,,,,Current number of existent backups,0,velero,,,
2+
velero.backup.amount,gauge,,,,Current number of existent backups,0,velero,,,
33
velero.backup.attempt.count,count,,,,Total number of attempted backups,0,velero,,,
44
velero.backup.deletion.attempt.count,count,,,,Total number of attempted backup deletions,0,velero,,,
55
velero.backup.deletion.failure.count,count,,,,Total number of failed backup deletions,0,velero,,,
@@ -32,7 +32,7 @@ velero.pod_volume.operation_latency.seconds.bucket,count,,,,"Histogram bucket fo
3232
velero.pod_volume.operation_latency.seconds.count,count,,,,Count aggregation for time taken to complete pod volume operations,0,velero,,,
3333
velero.pod_volume.operation_latency.seconds.gauge,gauge,,,,"Gauge metric indicating time taken, in seconds, to perform pod volume operations",0,velero,,,
3434
velero.pod_volume.operation_latency.seconds.sum,count,,,,"Sum aggregation for time taken to complete pod volume operations, in seconds",0,velero,,,
35-
velero.restore,gauge,,,,Current number of existent restores,0,velero,,,
35+
velero.restore.amount,gauge,,,,Current number of existent restores,0,velero,,,
3636
velero.restore.attempt.count,count,,,,Total number of attempted restores,0,velero,,,
3737
velero.restore.failed.count,count,,,,Total number of failed restores,0,velero,,,
3838
velero.restore.partial_failure.count,count,,,,Total number of partially failed restores,0,velero,,,

velero/tests/common.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def get_fixture_path(filename):
4040
'velero.backup.last_status': 'gauge',
4141
'velero.backup.partial_failure.count': 'monotonic_count',
4242
'velero.backup.success.count': 'monotonic_count',
43-
'velero.backup': 'gauge',
43+
'velero.backup.amount': 'gauge',
4444
'velero.backup.validation_failure.count': 'monotonic_count',
4545
'velero.backup.warning.count': 'monotonic_count',
4646
'velero.csi_snapshot.attempt.count': 'monotonic_count',
@@ -50,7 +50,7 @@ def get_fixture_path(filename):
5050
'velero.restore.failed.count': 'monotonic_count',
5151
'velero.restore.partial_failure.count': 'monotonic_count',
5252
'velero.restore.success.count': 'monotonic_count',
53-
'velero.restore': 'gauge',
53+
'velero.restore.amount': 'gauge',
5454
'velero.restore.validation_failed.count': 'monotonic_count',
5555
'velero.volume_snapshot.attempt.count': 'monotonic_count',
5656
'velero.volume_snapshot.failure.count': 'monotonic_count',

0 commit comments

Comments
 (0)