Revert [NDMII-3310] add support for HA for integrations (#19671)

Author: jedupau

datadog_checks_base/changelog.d/19671.fixed

@@ -0,0 +1 @@
+Remove HA_SUPPORTED as a class attribute to the AgentCheck to let integrations self declare that they support HA.

datadog_checks_base/datadog_checks/base/checks/base.py

@@ -164,8 +164,6 @@ class except the `check` method but sometimes it might be useful for a Check to
     # See https://github.com/DataDog/integrations-core/pull/2093 for more information.
     DEFAULT_METRIC_LIMIT = 0
 
-    HA_SUPPORTED = False
-
     # Allow tracing for classic integrations
     def __init_subclass__(cls, *args, **kwargs):
         try:
@@ -314,14 +312,6 @@ def __init__(self, *args, **kwargs):
         if os.environ.get("GOFIPS", "0") == "1":
             enable_fips()
 
-        ha_enabled_init = self.init_config.get('ha_enabled', False) if self.init_config else False
-        ha_enabled_instance = self.instance.get('ha_enabled', False) if self.instance else False
-
-        if not self.HA_SUPPORTED and (ha_enabled_init or ha_enabled_instance):
-            raise ConfigurationError(
-                f"High Availability is enabled for check {self.name} but this integration does not support it"
-            )
-
     def _create_metrics_pattern(self, metric_patterns, option_name):
         all_patterns = metric_patterns.get(option_name, [])
 

datadog_checks_base/tests/base/checks/test_agent_check.py

@@ -11,7 +11,7 @@
 import mock
 import pytest
 
-from datadog_checks.base import AgentCheck, ConfigurationError, to_native_string
+from datadog_checks.base import AgentCheck, to_native_string
 from datadog_checks.base import __version__ as base_package_version
 
 from .utils import BaseModelTest
@@ -1310,23 +1310,3 @@ def test_env_var_logic_preset():
         AgentCheck()
         assert os.getenv('OPENSSL_CONF', None) == preset_conf
         assert os.getenv('OPENSSL_MODULES', None) == preset_modules
-
-
-def test_ha_enabled_and_unsupported():
-    class TestNonHACheck(AgentCheck):
-        HA_SUPPORTED = False
-
-    TestNonHACheck('test', {}, [{}])
-    with pytest.raises(ConfigurationError):
-        TestNonHACheck('test', {'ha_enabled': True}, [{}])
-    with pytest.raises(ConfigurationError):
-        TestNonHACheck('test', {}, [{'ha_enabled': True}])
-
-
-def test_ha_enabled_and_supported():
-    class TestHACheck(AgentCheck):
-        HA_SUPPORTED = True
-
-    TestHACheck('test', {}, [{}])
-    TestHACheck('test', {'ha_enabled': True}, [{}])
-    TestHACheck('test', {}, [{'ha_enabled': True}])