Remove baremetal allocations microversion check (#17791)

* Remove baremetal allocations microversion check

* Remove test_allocations_low_microversion

* Added changelog

* Added changelog

* Remove 'removed' changelog

* Remove microversion check for allocations in sdk api

* Remove no longer needed REST_IRONIC_MICROVERSION_1_10

* Remove no longer needed SDK_IRONIC_MICROVERSION_1_10

Author: jose-manuel-almaza

openstack_controller/changelog.d/17791.fixed

@@ -0,0 +1 @@
+Remove baremetal allocations microversion check

openstack_controller/datadog_checks/openstack_controller/api/api_rest.py

@@ -473,12 +473,6 @@ def get_baremetal_drivers(self):
         return response.json().get('drivers', [])
 
     def get_baremetal_allocations(self):
-        if float(self.config.ironic_microversion) < 1.52:
-            self.log.info(
-                "Ironic microversion is below 1.52 and set to %s, cannot collect allocations",
-                self.config.ironic_microversion,
-            )
-            return []
         return self.make_paginated_request(
             '{}/v1/allocations'.format(self._catalog.get_endpoint_by_type(Component.Types.BAREMETAL.value)),
             'allocations',

openstack_controller/datadog_checks/openstack_controller/api/api_sdk.py

@@ -298,12 +298,6 @@ def get_baremetal_drivers(self):
         return [driver.to_dict(original_names=True) for driver in self.connection.baremetal.drivers()]
 
     def get_baremetal_allocations(self):
-        if float(self.config.ironic_microversion) < 1.52:
-            self.log.info(
-                "Ironic microversion is below 1.52 and set to %s, cannot collect allocations",
-                self.config.ironic_microversion,
-            )
-            return []
         return [
             allocation.to_dict(original_names=True)
             for allocation in self.call_paginated_api(

openstack_controller/tests/configs.py

@@ -237,14 +237,6 @@
     'use_legacy_check_version': False,
 }
 
-REST_IRONIC_MICROVERSION_1_10 = {
-    'keystone_server_url': 'http://127.0.0.1:8080/identity',
-    'username': 'admin',
-    'password': 'password',
-    'ironic_microversion': '1.10',
-    'use_legacy_check_version': False,
-}
-
 REST_MICROVERSION_3_70 = {
     'keystone_server_url': 'http://127.0.0.1:8080/identity',
     'username': 'admin',
@@ -468,13 +460,6 @@
     'use_legacy_check_version': False,
 }
 
-SDK_IRONIC_MICROVERSION_1_10 = {
-    'openstack_cloud_name': 'test_cloud',
-    'openstack_config_file_path': TEST_OPENSTACK_CONFIG_UNIT_TESTS_PATH,
-    'ironic_microversion': '1.10',
-    'use_legacy_check_version': False,
-}
-
 SDK_MICROVERSION_3_70 = {
     'openstack_cloud_name': 'test_cloud',
     'openstack_config_file_path': TEST_OPENSTACK_CONFIG_UNIT_TESTS_PATH,

openstack_controller/tests/test_unit_ironic.py

@@ -507,30 +507,6 @@ def test_allocations_metrics(aggregator, check, dd_run_check, metrics):
         )
 
 
-@pytest.mark.parametrize(
-    ('instance'),
-    [
-        pytest.param(
-            configs.REST_IRONIC_MICROVERSION_1_10,
-            id='api rest microversion default',
-        ),
-        pytest.param(
-            configs.SDK_IRONIC_MICROVERSION_1_10,
-            id='api sdk microversion default',
-        ),
-    ],
-)
-@pytest.mark.usefixtures('mock_http_get', 'mock_http_post', 'openstack_connection')
-def test_allocations_low_microversion(aggregator, check, dd_run_check, caplog):
-    caplog.set_level(logging.INFO)
-    dd_run_check(check)
-    assert 'Ironic microversion is below 1.52 and set to 1.10, cannot collect allocations' in caplog.text
-    aggregator.assert_metric(
-        'openstack.ironic.allocation.count',
-        count=0,
-    )
-
-
 @pytest.mark.parametrize(
     ('connection_baremetal', 'instance', 'paginated_limit', 'api_type', 'expected_api_calls'),
     [