fix kafka and move urllib3 comment

sarah-witt · sarah-witt · commit cc9eee5cfa51 · 2025-05-12T14:41:19.000-04:00
diff --git a/datadog_checks_base/pyproject.toml b/datadog_checks_base/pyproject.toml
@@ -33,6 +33,8 @@ license = "BSD-3-Clause"
 db = [
     "mmh3==5.1.0",
 ]
+# urllib3 is a dependency of requests that we explicitly
+# make use of in a few places
 deps = [
     "binary==1.0.1",
     "cachetools==5.5.2",
diff --git a/kafka_consumer/hatch.toml b/kafka_consumer/hatch.toml
@@ -5,7 +5,7 @@
 # Also bump the LIBRDKAFKA_VERSION version in this file
 post-install-commands = [
   "python -m pip uninstall -y confluent-kafka",
-  "python -m pip install --no-binary confluent-kafka confluent-kafka==2.10.0",
+  "python -m pip install --no-binary confluent-kafka confluent-kafka==2.8.0",
 ]
 
 [envs.default.env-vars]

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,8 @@ license = "BSD-3-Clause"`
`33`	`33`	`db = [`
`34`	`34`	`"mmh3==5.1.0",`
`35`	`35`	`]`
	`36`	`+# urllib3 is a dependency of requests that we explicitly`
	`37`	`+# make use of in a few places`
`36`	`38`	`deps = [`
`37`	`39`	`"binary==1.0.1",`
`38`	`40`	`"cachetools==5.5.2",`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`# Also bump the LIBRDKAFKA_VERSION version in this file`
`6`	`6`	`post-install-commands = [`
`7`	`7`	`"python -m pip uninstall -y confluent-kafka",`
`8`		`- "python -m pip install --no-binary confluent-kafka confluent-kafka==2.10.0",`
	`8`	`+ "python -m pip install --no-binary confluent-kafka confluent-kafka==2.8.0",`
`9`	`9`	`]`
`10`	`10`
`11`	`11`	`[envs.default.env-vars]`