Bring latest from master

Author: AAraKKe

.github/CODEOWNERS

@@ -6,14 +6,14 @@
 *                   @DataDog/agent-integrations
 
 # Documentation
-/docs/                @DataDog/documentation @DataDog/agent-integrations
-*.md                  @DataDog/documentation @DataDog/agent-integrations
+/docs/                @DataDog/agent-integrations
+**/README.md          @DataDog/documentation @DataDog/agent-integrations
 conf.yaml.example     @DataDog/documentation @DataDog/agent-integrations
 conf.yaml.default     @DataDog/documentation @DataDog/agent-integrations
 auto_conf.yaml        @DataDog/documentation @DataDog/agent-integrations @DataDog/container-integrations
 manifest.json         @DataDog/documentation @DataDog/agent-integrations
 **/assets             @DataDog/documentation @DataDog/agent-integrations
-
+**/metadata.csv       @DataDog/documentation @DataDog/agent-integrations
 
 # Dependencies
 /.deps/                            @DataDog/agent-integrations @DataDog/agent-delivery
@@ -120,7 +120,7 @@ manifest.json         @DataDog/documentation @DataDog/agent-integrations
 /network_path/*.md                                                 @DataDog/network-device-monitoring @DataDog/Networks @DataDog/agent-integrations @DataDog/documentation
 
 /datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/ @DataDog/ndm-core @DataDog/agent-integrations
-/docs/developer/tutorials/snmp/                                    @DataDog/ndm-core @DataDog/agent-integrations @DataDog/documentation
+/docs/developer/tutorials/snmp/                                    @DataDog/ndm-core @DataDog/agent-integrations
 
 # System checks
 /disk/                                    @DataDog/agent-integrations @DataDog/windows-agent

.gitlab-ci.yml

@@ -128,27 +128,37 @@ release-manual:
 tagger-image-builder:
   stage: build
   image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/docker:24.0.4-gbi-focal
-  only:
-    changes:
-      - .gitlab/tagger/**/*
-      - ddev/**/*
-      - .gitlab-ci.yml
-    refs:
-      - master
+  rules:
+    - if: $CI_PIPELINE_SOURCE == 'schedule'
+      when: never
+    - if: $CI_COMMIT_TAG
+      when: never
+    - if: $CI_COMMIT_BRANCH == 'master'
+      when: always
+    - changes:
+        - .gitlab/tagger/**/*
+        - ddev/**/*
+        - .gitlab-ci.yml
+    # Allow to manually trigger a build if we need to
+    - when: manual
+      allow_failure: true
   script:
     - docker buildx build --tag $TAGGER_IMAGE -f .gitlab/tagger/Dockerfile . --push
-  except: [ tags, schedules ]
   tags: [ "arch:amd64" ]
 
 validate-log-intgs-builder:
   stage: build
   image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/docker:24.0.4-gbi-focal
-  only:
-    changes:
-      - .gitlab/validate-logs-intgs/**/*
-      - .gitlab-ci.yml
-    refs:
-      - master
+  rules:
+    - if: $CI_PIPELINE_SOURCE == 'schedule'
+      when: never
+    - if: $CI_COMMIT_TAG
+      when: never
+    - if: $CI_COMMIT_BRANCH == 'master'
+      when: always
+    - changes:
+        - .gitlab/validate-logs-intgs/**/*
+        - .gitlab-ci.yml
   script:
     - cd .gitlab/validate-logs-intgs/
     - docker buildx build --tag $VALIDATE_LOG_INTGS . --push

datadog_checks_base/changelog.d/20355.fixed

@@ -0,0 +1 @@
+Fix tracemalloc usage error

datadog_checks_base/datadog_checks/base/checks/base.py

@@ -1305,10 +1305,10 @@ def run(self):
 
                     enter_pdb(self.check, line=self.init_config['set_breakpoint'], args=(instance,))
                 elif self.should_profile_memory():
-                    # self.init_config['profile_memory'] could be `/tmp/datadog-agent-memory-profiler*`
+                    # self.init_config.get('profile_memory') could be `/tmp/datadog-agent-memory-profiler*`
                     # that is generated by Datadog Agent.
                     # If we use `--m-dir` for `agent check` command, a hidden flag, it should be same as a given value.
-                    namespaces = [self.init_config['profile_memory']]
+                    namespaces = [self.init_config.get('profile_memory')]
                     for id in self.check_id.split(":"):
                         namespaces.append(id)
                     self.profile_memory(func=self.check, namespaces=namespaces, args=(instance,))

datadog_checks_base/tests/base/checks/test_agent_check.py

@@ -1316,3 +1316,24 @@ def test_env_var_logic_preset():
         AgentCheck()
         assert os.getenv('OPENSSL_CONF', None) == preset_conf
         assert os.getenv('OPENSSL_MODULES', None) == preset_modules
+
+
+@pytest.mark.parametrize(
+    "should_profile_value, expected_calls",
+    [
+        (True, 1),
+        (False, 0),
+    ],
+)
+def test_profile_memory(should_profile_value, expected_calls):
+    """
+    Test that profile_memory is called when should_profile_memory is True
+    """
+    check = AgentCheck('test', {}, [{}])
+    check.should_profile_memory = mock.MagicMock(return_value=should_profile_value)
+    check.profile_memory = mock.MagicMock()
+
+    check.run()
+
+    assert check.should_profile_memory.call_count == 1
+    assert check.profile_memory.call_count == expected_calls

datadog_checks_dev/changelog.d/20292.added

@@ -0,0 +1 @@
+Update release tag to ensure that tags are fetched before getting the list of tags

datadog_checks_dev/datadog_checks/dev/tooling/commands/release/tag.py

@@ -3,7 +3,7 @@
 # Licensed under a 3-clause BSD style license (see LICENSE)
 import click
 
-from ...git import git_tag, git_tag_list
+from ...git import git_fetch, git_tag, git_tag_list
 from ...release import get_release_tag_string
 from ...utils import complete_valid_checks, get_valid_checks, get_version_string
 from ..console import CONTEXT_SETTINGS, abort, echo_info, echo_success, echo_waiting, echo_warning
@@ -19,7 +19,8 @@
 @click.option('--push/--no-push', default=True)
 @click.option('--dry-run', '-n', is_flag=True)
 @click.option('--skip-prerelease', is_flag=True)
-def tag(check, version, push, dry_run, skip_prerelease):
+@click.option('--fetch/--no-fetch', default=True)
+def tag(check, version, push, dry_run, skip_prerelease, fetch):
     """Tag the HEAD of the git repo with the current release number for a
     specific check. The tag is pushed to origin by default.
 
@@ -28,6 +29,13 @@ def tag(check, version, push, dry_run, skip_prerelease):
     Notice: specifying a different version than the one in `__about__.py` is
     a maintenance task that should be run under very specific circumstances
     (e.g. re-align an old release performed on the wrong commit).
+
+    Return codes:
+    0: Success
+    1: Invalid command call
+    2: Nothing to tag
+    3: Failed to fetch tags
+    Other: Git tag command returned a non-zero exit code
     """
     tagging_all = check == 'all'
 
@@ -44,6 +52,13 @@ def tag(check, version, push, dry_run, skip_prerelease):
 
     # Check for any new tags
     tagged = False
+    # Fetch all tags from the remote
+    if fetch:
+        echo_info('Fetching all tags from remote...')
+
+        if (result := git_fetch(tags=True)).code != 0:
+            abort(f'Failed to fetch tags: {result.stderr}', 3)
+
     existing_tags = git_tag_list()
 
     for check in checks:

datadog_checks_dev/datadog_checks/dev/tooling/git.py

@@ -7,7 +7,7 @@
 from semver import VersionInfo
 
 from ..fs import chdir
-from ..subprocess import run_command
+from ..subprocess import SubprocessResult, run_command
 from .constants import get_root
 
 
@@ -144,6 +144,17 @@ def git_tag(tag_name, push=False):
         return result
 
 
+def git_fetch(remote: str = 'origin', tags: bool = False) -> SubprocessResult:
+    """
+    Fetch all tags from the remote
+    """
+    with chdir(get_root()):
+        cmd = ['git', 'fetch', remote]
+        if tags:
+            cmd.append('--tags')
+        return run_command(cmd, capture=True)
+
+
 def git_tag_list(pattern=None, contains=None):
     """
     Return a list of all the tags in the git repo matching a regex passed in

datadog_checks_dev/tests/tooling/test_git.py

@@ -2,13 +2,15 @@
 # All rights reserved
 # Licensed under a 3-clause BSD style license (see LICENSE)
 import mock
+import pytest
 
 from datadog_checks.dev.tooling.constants import set_root
 from datadog_checks.dev.tooling.git import (
     files_changed,
     get_commits_since,
     get_current_branch,
     git_commit,
+    git_fetch,
     git_show_file,
     git_tag,
     git_tag_list,
@@ -200,3 +202,20 @@ def test_tracked_by_git():
             tracked_by_git('bar')
             chdir.assert_called_once_with('/foo/')
             run.assert_called_once_with('git ls-files --error-unmatch bar', capture=True)
+
+
+@pytest.mark.parametrize(
+    'tags, expected_command',
+    [
+        (True, ['git', 'fetch', 'origin', '--tags']),
+        (False, ['git', 'fetch', 'origin']),
+    ],
+    ids=['with_tags', 'without_tags'],
+)
+def test_git_fetch(tags: bool, expected_command: list[str]):
+    with mock.patch('datadog_checks.dev.tooling.git.chdir') as chdir:
+        with mock.patch('datadog_checks.dev.tooling.git.run_command') as run:
+            set_root('/foo/')
+            git_fetch(tags=tags)
+            chdir.assert_called_once_with('/foo/')
+            run.assert_called_once_with(expected_command, capture=True)

ddev/tests/conftest.py

@@ -145,6 +145,10 @@ def isolation() -> Generator[Path, None, None]:
 def local_clone(isolation, local_repo) -> Generator[ClonedRepo, None, None]:
     cloned_repo_path = isolation / local_repo.name
 
+    # Get the current origin remote url
+    with local_repo.as_cwd():
+        origin_url = PLATFORM.check_command_output(['git', 'remote', 'get-url', 'origin']).strip()
+
     PLATFORM.check_command_output(
         ['git', 'clone', '--local', '--shared', '--no-tags', str(local_repo), str(cloned_repo_path)]
     )
@@ -154,6 +158,11 @@ def local_clone(isolation, local_repo) -> Generator[ClonedRepo, None, None]:
         PLATFORM.check_command_output(['git', 'config', 'commit.gpgsign', 'false'])
         PLATFORM.check_command_output(['git', 'config', 'tag.gpgsign', 'false'])
 
+        # Set url to point to the origin of the local source and not to the local repo
+        PLATFORM.check_command_output(['git', 'remote', 'set-url', 'origin', origin_url])
+        # Now fetch latest updates
+        PLATFORM.check_command_output(['git', 'fetch', 'origin'])
+
     cloned_repo = ClonedRepo(cloned_repo_path, 'origin/master', 'ddev-testing')
     cloned_repo.reset_branch()
 

gpu/README.md

@@ -114,6 +114,8 @@ datadog:
 
 For **mixed environments**, two different Helm charts need to be deployed with different affinity sets and with one of them joining the other's Cluster Agent [as documented here](https://github.com/DataDog/helm-charts/tree/main/charts/datadog#how-to-join-a-cluster-agent-from-another-helm-chart-deployment-linux).
 
+While the `nvidia.com/gpu.present` tag is commonly used to identify GPU nodes (often automatically added by the NVIDIA GPU operator), your specific environment might use different tags or labeling schemes. It's important to identify the correct tag and value that distinguishes your GPU nodes from non-GPU nodes. You can then adapt the examples below accordingly.
+
 Assuming we have already a `values.yml` file for a regular, non-GPU deployment, the steps to enable GPU monitoring only on GPU nodes are the following:
 
 1. In `agents.affinity`, add a node selector that stops the non-GPU Agent from running on GPU nodes:
@@ -132,7 +134,7 @@ agents:
               - "true"
 ```
 
-The `nvidia.com/gpu.present` tag is used above as it's automatically added to GPU nodes by the NVIDIA GPU operator. However, any other appropriate tag may be chosen.
+Additionally, if you need to select nodes based on the presence of a label key, irrespective of its value, you can use the `Exists` [operator](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#node-affinity). Conversely, to exclude nodes that have a specific label key, you can use `DoesNotExist`. For example, to select nodes that have the label `custom.gpu/available` (regardless of its value), you would use `operator: Exists`.
 
 2. Create another file (for example, `values-gpu.yaml`) to apply on top of the previous one. In this file, enable GPU monitoring, configure the Cluster Agent to join the existing cluster as per the [instructions],(<https://github.com/DataDog/helm-charts/tree/main/charts/datadog#how-to-join-a-cluster-agent-from-another-helm-chart-deployment-linux>) and include the affinity for the GPU nodes:
 

ivanti_nzta/manifest.json

@@ -2,7 +2,7 @@
   "manifest_version": "2.0.0",
   "app_uuid": "c161337b-578b-4c24-bc14-adf35e0ee0ed",
   "app_id": "ivanti-nzta",
-  "display_on_public_website": false,
+  "display_on_public_website": true,
   "tile": {
     "overview": "README.md#Overview",
     "configuration": "README.md#Setup",