Do not fail if no tags are provided in the config (#17598)

* Do not fail if no tags are provided in the config

* remove breakpoint()

* added changelog and fix broken test

* nit

Author: Kyle-Neale

vault/changelog.d/17598.fixed

@@ -0,0 +1 @@
+Do not fail if no tags are provided in the config

vault/datadog_checks/vault/check.py

@@ -213,7 +213,8 @@ def parse_config(self):
         self._api = Api(**methods)
 
         tags = [f'api_url:{self._api_url}']
-        tags.extend(self.config.tags)
+        if self.config.tags:
+            tags.extend(self.config.tags)
         self._tags = tuple(tags)
 
     def configure_scrapers(self):

vault/tests/test_vault.py

@@ -33,6 +33,19 @@ def test_bad_config(self, aggregator, dd_run_check, use_openmetrics):
 
         aggregator.assert_service_check(Vault.SERVICE_CHECK_CONNECT, count=0)
 
+    @pytest.mark.parametrize('use_openmetrics', [False, True], indirect=True)
+    def test_no_extra_tags(self, aggregator, dd_run_check, use_openmetrics):
+        instance = {'use_openmetrics': use_openmetrics}
+        instance.update(INSTANCES['main'])
+        instance.pop('tags')
+
+        c = Vault(Vault.CHECK_NAME, {}, [instance])
+
+        tag = ['api_url:{}'.format(INSTANCES['main']['api_url'])]
+        dd_run_check(c)
+
+        aggregator.assert_service_check(Vault.SERVICE_CHECK_CONNECT, status=Vault.OK, count=1, tags=tag)
+
     @pytest.mark.parametrize('use_openmetrics', [False, True], indirect=True)
     def test_unsupported_api_version_fallback(self, aggregator, dd_run_check, use_openmetrics):
         instance = {'use_openmetrics': use_openmetrics}