Add the Teleport Integration #16877
Merged
Add the Teleport Integration #16877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
The |
|
The |
NouemanKHAL
force-pushed
the
noueman/add-teleport-integration
branch
from
7c8ad20 to
a69ac09
Compare
|
The |
Test Results 2 files 2 suites 17s ⏱️ Results for commit 892dafc. ♻️ This comment has been updated with latest results. |
|
The |
|
The |
|
The |
|
The |
|
The |
|
The |
|
The |
|
The |
* update description 'cluster' -> 'instance' * change teleport.auth.audit_log.* prefix to teleport.audit_log.* to ease filtering audit log metrics * standardize metric names in the tests * update implementation * update metadata.csv * remove extra space in metadata.csv * audit_log -> auth.audit_log
* update description 'cluster' -> 'instance' * send count metric instead of service check * raise on exception * format * fix integration tests * remove obsolete field version in docker-compose.yml * fix msg arg to self.count and add teleport_status tag to health.up metric * fix integration tests typo * fix e2e tests * log error message on exception * lint * add teleport.health.up to metadata.csv * add assertion for unreachable health state metric tag * apply suggestion
* regenerate metadata.csv * add all missing descriptions * add some units * add bucket,sum, and count metrics for histogram metrics * update units and sort
|
Tracking documentation review with DOCS-7816 |
cswatt
added
the
editorial review
iliakur
requested changes
Apr 26, 2024
Co-authored-by: Ilia Kurenkov <ilia.kurenkov@datadoghq.com>
iliakur
approved these changes
Apr 26, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* initial integration scaffolding * add initial setup for integration tests using docker-compose * add first integration test * critical test pass * add test_connect_ok * fix test_connect_exception and passing test_connect_ok * add test to check common metrics collection * add metadata.csv * ddev test teleport -fs * delete some comments * wip: use openmetrics base class * catch main super.check exception, passing -> first two tests * move exception to test to unit tests * add unit tests, setup mocks, fix integration tests * assert common metrics in unit tests * add metrics fixture * add teleport_cache_stale_events mocks * reporting common metrics * rename 'version' tag to 'teleport_version' * format * remove docker-compose down nothing behavior * update metadata.csv metric names format * update unit and integration tests to match the new metric names * fix implementation to pass the tests * [PLINT-302] Report Teleport Proxy metrics (#17018) * add unit tests for proxy metrics * passing metrics that don't require mocks * tests passing for grpc_client_* metrics * separate unit tests by teleport metrics groups * update teleport proxy metrics test to check all metrics * update fixtures with missing proxy metrics * update proxy metric names in the test * collect proxy metrics in the check * format * ignore linting on a long line * separate metrics maps into metrics.py per suggestion * ddev validate ci --sync * ddev validate config teleport -s * ddev validate models teleport -s * ddev validate labeler --sync * remove arch suffix from docker-compose teleport image * add E2E test * fix linting * [PLINT-303] Report Teleport Auth Service and Backends metrics (#17050) * add test_auth_teleport_metrics test collect auth service metrics update fixtures with missing auth service metrics format add 'cluster_name_not_found' metric fix wrong metrics, grpc_server metrics belong to Auth service replace single quotes with double quotes + format change prefix for auth audit_log metrics add auth s3 backend metrics test collect auth s3 backend metrics update fixtures with auth s3 backend metrics * add support for backend cache metrics * add support for backend dynamoDB metrics * add support for backend firestore metrics * add support for backend GCP GCS metrics * add support for backend ETCD metrics * lint * Refactor and cleanup Teleport Integration (#17084) * use metrics_path fixture in tests * use instance fixture in tests * move metrics constants in tests to common.py * handle check exception * remove the match parameter when testing for exception * add .common prefix to common instance metrics for filtering purposes later * update integration tests * fix linting * fix e2e tests * use the COMMON_METRICS const in the integration and e2e tests * format * use the INSTANCE const in the test_e2e.py * update the config properties to align with the RFC suggestion * lint * make DEFAULT_DIAG_PORT class constant * [PLINT-304] Report metrics for the Teleport SSH Service (#17111) * use metrics_path fixture in tests * use instance fixture in tests * move metrics constants in tests to common.py * handle check exception * remove the match parameter when testing for exception * add .common prefix to common instance metrics for filtering purposes later * update integration tests * fix linting * fix e2e tests * use the COMMON_METRICS const in the integration and e2e tests * format * use the INSTANCE const in the test_e2e.py * update the config properties to align with the RFC suggestion * lint * make DEFAULT_DIAG_PORT class constant * add tests for SSH service metrics * collect SSH metrics, tests passing * cleanup: move METRIC_MAP to metrics.py * [PLINT-306] Report metrics for the Teleport Kubernetes Service (#17113) * add tests for Kubernetes service metrics * successfully collecting kubernetes client metrics * add tests for Kubernetes service server metrics * successfully collecting kubernetes server metrics * [PLINT-305] Report metrics for the Teleport Database Service (#17114) * add tests for Database service metrics * successfully collecting database service metrics * [PLINT-308] Report metrics for the Teleport Enhanced Session Recording / BPF (#17116) * add tests for BPF metrics * successfully collecting BPF metrics * [PLINT-307] Report metrics for the Teleport internal Prometheus (#17117) * add tests for Prometheus metrics * successfully collecting Prometheus metrics * [PLINT-326] Add `teleport_service` tag to Teleport metrics (#17216) * update tests to check for 'teleport_service' tag for auth metrics * update tests to check for 'teleport_service' tag for ssh metrics * update tests to check for 'teleport_service' tag for proxy metrics * update tests to check for 'teleport_service' tag for database metrics * update tests to check for 'teleport_service' tag for kubernetes metrics * update tests to check for 'teleport_service' tag for common teleport metrics * add METRIC_MAP_BY_SERVICE * add custom metric transformer to add 'teleport_service' tag * remove unexisting metric type case * remove useless check * [PLINT-331] Update `metadata.csv` for the Teleport Integration (#17241) * update metadata.csv * fix metadata duplications, and invalid histogram types to their corresponding count type * remove periods at the end of descriptions * [PLINT-325] Update Teleport Configuration spec (#17261) * add 'teleport_url' and 'diag_port' properties to the Configuration Spec * ddev validate config -s * ddev validate models * sort metadata.csv * ddev validate ci -s * add DEFAULT_METRIC_LIMIT to fix the openmetrics validation-n * update classifier_tags * add description to the manifest * fix tile description * update manifest check for metrics * [WIP] add dashboard * add dashboard entry in the manifest.json * delele monitors, logs, and saved_views entries from the manifest.json * remove extra comma in manifest.json * changelog * ddev validate label --sync * [PLINT-362] Standardize metric names (#17383) * update description 'cluster' -> 'instance' * change teleport.auth.audit_log.* prefix to teleport.audit_log.* to ease filtering audit log metrics * standardize metric names in the tests * update implementation * update metadata.csv * remove extra space in metadata.csv * audit_log -> auth.audit_log * Send Teleport service check as a metric (#17441) * update description 'cluster' -> 'instance' * send count metric instead of service check * raise on exception * format * fix integration tests * remove obsolete field version in docker-compose.yml * fix msg arg to self.count and add teleport_status tag to health.up metric * fix integration tests typo * fix e2e tests * log error message on exception * lint * add teleport.health.up to metadata.csv * add assertion for unreachable health state metric tag * apply suggestion * Update metadata.csv with descriptions and units (#17456) * regenerate metadata.csv * add all missing descriptions * add some units * add bucket,sum, and count metrics for histogram metrics * update units and sort * fix manifest.json errors * update README.md with prerequisites section * delete dashboard * Apply suggestions from code review Co-authored-by: Ilia Kurenkov <ilia.kurenkov@datadoghq.com> --------- Co-authored-by: Ilia Kurenkov <ilia.kurenkov@datadoghq.com> 8aed42a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
PLINT-282
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.