Skip to content

Adding schema collection to sqlserver #17258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 132 commits into from
Jun 20, 2024
Merged

Adding schema collection to sqlserver #17258

merged 132 commits into from
Jun 20, 2024

Conversation

kozlovb
Copy link
Contributor

@kozlovb kozlovb commented Mar 22, 2024 •
edited
Loading

What does this PR do?

This PR will allow to collect schemas in sqlserver integration.

Motivation

Schemas contribute significantly to improving the observability of databases.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@kozlovb kozlovb requested review from a team as code owners March 22, 2024 10:09
@kozlovb kozlovb marked this pull request as draft March 22, 2024 11:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

8 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@kozlovb kozlovb force-pushed the BorisKozlov-DBMON-3770 branch from 451f2e1 to 7fff439 Compare April 16, 2024 08:19
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

4 similar comments
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

3 similar comments
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

kozlovb
kozlovb commented Apr 24, 2024
View reviewed changes
sqlserver/hatch.toml Outdated
post-install-commands = [
"python -m pip install deepdiff",
]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag deepdiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Test Results

  2 files    2 suites   4m 5s ⏱️
481 tests 476 ✅  5 💤 0 ❌
962 runs  933 ✅ 29 💤 0 ❌

Results for commit e43e6cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@kozlovb kozlovb merged commit 2b3e48c into master Jun 20, 2024
39 checks passed
@kozlovb kozlovb deleted the BorisKozlov-DBMON-3770 branch June 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dujuku dujuku dujuku left review comments

@iliakur iliakur iliakur left review comments

@nenadnoveljic nenadnoveljic nenadnoveljic left review comments

@lu-zhengda lu-zhengda lu-zhengda approved these changes

@jmeunier28 jmeunier28 jmeunier28 left review comments

Assignees
No one assigned
Labels
base_package ddev documentation integration/postgres integration/sqlserver team/agent-integrations team/database-monitoring-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kozlovb @dujuku @iliakur @lu-zhengda @jmeunier28 @nenadnoveljic