Skip to content

Include schema in filter for indexes #17480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Apr 29, 2024

What does this PR do?

Fixes a bug where multiple schemas with tables of the same name were reporting all indexes across schemas. Also fixes a similar bug for partitions.

Motivation

Indexes should be reported per table/schema.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

github-actions bot commented Apr 29, 2024

Test Results

   16 files     16 suites   21m 28s ⏱️
  286 tests   284 ✅   2 💤 0 ❌
2 296 runs  2 181 ✅ 115 💤 0 ❌

Results for commit b83cf97.

♻️ This comment has been updated with latest results.

@sethsamuel sethsamuel merged commit 3d4357c into master Apr 29, 2024
39 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/DBMON-3986-Postgres-integration-is-incorrectly-querying-for-indexes-across-all-schemas branch April 29, 2024 20:46
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request Apr 29, 2024
Kyle-Neale pushed a commit that referenced this pull request Apr 30, 2024
(cherry picked from commit 3d4357c)

Co-authored-by: Seth Samuel <seth.samuel@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants