Skip to content

Add new handled exceptions #17773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Conversation

jose-manuel-almaza
Copy link
Contributor

What does this PR do?

Add new handled exceptions

Motivation

Cover more use cases in exception handling

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.87%. Comparing base (bc13164) to head (54e3164).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
couchbase ?
glusterfs ?
haproxy ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql ?
openstack_controller 94.24% <83.33%> (+0.02%) ⬆️
postgres ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

iliakur
iliakur previously approved these changes Jun 7, 2024
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests? ;)

dkirov-dd
dkirov-dd previously approved these changes Jun 7, 2024
Kyle-Neale
Kyle-Neale previously approved these changes Jun 7, 2024
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
@jose-manuel-almaza jose-manuel-almaza dismissed stale reviews from dkirov-dd and iliakur via 4649aa1 June 7, 2024 22:35
@jose-manuel-almaza jose-manuel-almaza merged commit dc7acd0 into master Jun 11, 2024
42 of 44 checks passed
@jose-manuel-almaza jose-manuel-almaza deleted the jose/add-new-handle-exceptions branch June 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants