Skip to content

Hyphen in database name support (SDBM-1013) #17775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

nenadnoveljic
Copy link
Contributor

@nenadnoveljic nenadnoveljic commented Jun 7, 2024

What does this PR do?

Fix the problem with databases that have hyphen in their name.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (f84cb70) to head (3bf98e1).
Report is 5 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory ?
activemq ?
activemq_xml ?
amazon_msk ?
ambari ?
apache ?
arangodb ?
argo_rollouts ?
argo_workflows ?
argocd ?
aspdotnet ?
avi_vantage ?
azure_iot_edge ?
boundary ?
btrfs ?
cacti ?
calico ?
cassandra ?
cert_manager ?
cisco_aci ?
citrix_hypervisor ?
cloud_foundry_api ?
cloudera ?
cockroachdb ?
consul ?
coredns ?
couch ?
crio ?
datadog_checks_base ?
datadog_checks_dev ?
datadog_checks_downloader ?
datadog_cluster_agent ?
dcgm ?
ddev ?
directory ?
disk ?
dns_check ?
dotnetclr ?
druid ?
ecs_fargate ?
eks_fargate ?
envoy ?
esxi ?
etcd ?
external_dns ?
fluentd ?
fluxcd ?
foundationdb ?
gearmand ?
gitlab_runner ?
go_expvar ?
gunicorn ?
harbor ?
hazelcast ?
hdfs_datanode ?
hdfs_namenode ?
hive ?
hivemq ?
http_check ?
hudi ?
ibm_db2 ?
ibm_i ?
ibm_mq ?
ibm_was ?
ignite ?
impala ?
istio ?
jboss_wildfly ?
kafka ?
karpenter ?
kong ?
kube_apiserver_metrics ?
kube_controller_manager ?
kube_dns ?
kube_metrics_server ?
kube_proxy ?
kube_scheduler ?
kubelet ?
kubernetes_cluster_autoscaler ?
kubernetes_state ?
kyototycoon ?
lighttpd ?
linkerd ?
linux_proc_extras ?
mapr ?
mapreduce ?
marathon ?
marklogic ?
mcache ?
mesos_master ?
mesos_slave ?
nagios ?
network ?
nfsstat ?
nginx ?
nginx_ingress_controller ?
nvidia_triton ?
openldap ?
openmetrics ?
openstack ?
openstack_controller ?
pgbouncer ?
php_fpm ?
postfix ?
powerdns_recursor ?
presto ?
process ?
prometheus ?
proxysql ?
pulsar ?
ray ?
redisdb ?
rethinkdb ?
riak ?
riakcs ?
silk ?
singlestore ?
snowflake ?
solr ?
spark ?
sqlserver 88.83% <86.48%> (?)
squid ?
statsd ?
strimzi ?
supervisord ?
system_core ?
system_swap ?
tcp_check ?
teamcity ?
tekton ?
teleport ?
temporal ?
teradata ?
tls ?
tokumx ?
torchserve ?
traefik_mesh ?
traffic_server ?
twemproxy ?
twistlock ?
varnish ?
vault ?
voltdb ?
vsphere ?
weaviate ?
win32_event_log ?
wmi_check ?
yarn ?
zk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

lu-zhengda
lu-zhengda previously approved these changes Jun 7, 2024
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@nenadnoveljic nenadnoveljic changed the title Hyphen in database name support Hyphen in database name support (SDBM-1013) Jun 10, 2024
@nenadnoveljic nenadnoveljic requested a review from lu-zhengda June 10, 2024 18:52
@nenadnoveljic nenadnoveljic merged commit 2552879 into master Jun 11, 2024
39 checks passed
@nenadnoveljic nenadnoveljic deleted the nenadnoveljic/SDBM-1013-sqlserver-hyphen branch June 11, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants