Run unit and e2e tests in parallel #19161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration to run unit and end-to-end tests in parallel by introducing a strategy matrix in the workflow. Key changes include:
- Adding a matrix strategy with a test_type parameter to distinguish unit and e2e jobs.
- Appending the matrix test type to environment variables and artifact names.
- Adjusting job conditions accordingly and updating the master workflow to trigger on pull requests to master.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test-target.yml | Added a strategy matrix and modified steps to run tests in parallel. |
| .github/workflows/master.yml | Added pull_request trigger on master to support the new testing flow. |
Comments suppressed due to low confidence (2)
.github/workflows/master.yml:7
- Confirm that adding a pull_request trigger for the master branch is intentional, as this change may lead to additional workflow runs which could affect CI utilization.
pull_request:
.github/workflows/test-target.yml:96
- Ensure that both unit and e2e tests have appropriate test coverage and that downstream steps correctly aggregate their respective artifacts based on the matrix test type.
matrix:
test_type: ['unit', 'e2e']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged