-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Aerospike agent and dashboards #19188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Aerospike agent and dashboards #19188
Conversation
modified check and metrics python scripts - -- to include all aerospike metrics most as gauge -- latency metrics are added as histograms added new dashboard covering key aerospike metrics required to be monitored includes, - cluster, node, namespace, sindex, sets, users, xdr, basic system-info and latencies
added CHANGELOG.md with details added and changed.
updated Aerospike pulgin version in about script
reverted the aerospike version to 4.0.0
reverted CHANGELOG.md to earlier and actual version generated changelog using ddev package from pypi with command "ddev release changelog new"
corrected the changelog files location
updated the correct PR number
The changelog type |
incorporated lint feedback and removed unnessary spaces
The changelog type |
removed unneceddary spaces at the end of the line as suggested in lint check
The changelog type |
removed unnecessary blank lines reported by lint at the end of file
The changelog type |
corrected comments
The changelog type |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
renamed label cluster_name as aerospike_cluster as it is forbidden as per github checks,
The changelog type |
added mapping for cluster_name to aerospike_cluster - updated check.py
The changelog type |
review feedback, removed unnecessary comments
PR Security UpdateAll commits in this PR up to and including 6609e88 have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack. |
@mphanias will take a look by eow |
@mphanias thanks for making the changes. There are some discussions outstanding that are blockers, please address them. |
metrics are now sent in datadog suggested format like aerospike.namespace.master_objects
…aerospike-datadog-integrations-core into aerospike-agent-and-dashboards
…aerospike-datadog-integrations-core into aerospike-agent-and-dashboards
What does this PR do?
Modified the aerospike integration to include all the metrics exposed by aerospike-pormetheus-exporter and multiple dashboard consuming the exported metrics.
Motivation
Expanding Metric Collection and Dashboards, we want to ensure all Aerospike metrics are available in datadog, so customers can have better visibility and provide actionable insights for key metrics, including performance, latency, and resource utilization.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged