Skip to content

Aerospike agent and dashboards #19188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 227 commits into
base: master
Choose a base branch
from

Conversation

mphanias
Copy link

@mphanias mphanias commented Dec 4, 2024

What does this PR do?

Modified the aerospike integration to include all the metrics exposed by aerospike-pormetheus-exporter and multiple dashboard consuming the exported metrics.

Motivation

Expanding Metric Collection and Dashboards, we want to ensure all Aerospike metrics are available in datadog, so customers can have better visibility and provide actionable insights for key metrics, including performance, latency, and resource utilization.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

mphanias and others added 3 commits November 26, 2024 10:57
modified check and metrics python scripts -
-- to include all aerospike metrics most as gauge
-- latency metrics are added as histograms

added new dashboard covering key aerospike metrics required to be monitored
includes,
- cluster, node, namespace, sindex, sets, users, xdr, basic system-info and latencies
updated Aerospike pulgin version in about script
reverted the aerospike version to 4.0.0
reverted CHANGELOG.md to earlier and actual version
generated changelog using ddev package from pypi with command "ddev release changelog new"
corrected the changelog files location
updated the correct PR number
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

incorporated lint feedback and removed unnessary spaces
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

removed unneceddary spaces at the end of the line as suggested in lint check
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

removed unnecessary blank lines reported by lint at the end of file
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.17%. Comparing base (87a21c0) to head (29cce4d).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
aerospike 88.39% <86.36%> (-0.45%) ⬇️
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

renamed label cluster_name as aerospike_cluster as it is forbidden as per github checks,
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

added mapping for cluster_name to aerospike_cluster - updated check.py
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

PR Security Update

All commits in this PR up to and including 6609e88 have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack.

@iliakur
Copy link
Contributor

iliakur commented Apr 30, 2025

@mphanias will take a look by eow

@iliakur
Copy link
Contributor

iliakur commented May 3, 2025

@mphanias thanks for making the changes. There are some discussions outstanding that are blockers, please address them.

@mphanias mphanias requested a review from iliakur May 22, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants