Add WLAN integration tile #19965

NouemanKHAL · 2025-03-31T13:27:55Z

What does this PR do?

Add the wlan (Wi-Fi) tile for the wlan agent corecheck.

Motivation

Provide out of the box dashboard and monitor template.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

F

wlan/README.md

Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com>

wlan/metadata.csv

…g/integrations-core into noueman/add-wlan-integration-tile

aliciascott · 2025-04-29T18:02:48Z

Thank you, I have created an editorial card for someone on our team to review further.

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

wlan/README.md

rtrieu

Noticed a couple of more things, but non-blocking. Approved!

wlan/README.md

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

Review from rtrieu is dismissed. Related teams and files:

documentation
- wlan/README.md

wlan/README.md

dkirov-dd

Approved with a couple of nits 👍

dkirov-dd · 2025-05-15T08:06:29Z

wlan/images/IMAGES_README.md

@@ -0,0 +1,41 @@
+# Marketplace Media Carousel Guidelines


I don't think we need this file/directory

dkirov-dd · 2025-05-15T08:39:18Z

wlan/assets/dashboards/wlan_overview.json

@@ -0,0 +1,894 @@
+{


Dashboard looks very good.
Nit: we usually try to limit the color space to 1 or 2 colors for the groups

Oh, a couple more things you can add:

the text from the overview group to the description dropdown accessed from the dashboard name

a note for a quick overview of each group

I'm not sure I understand the last comment, but I realized that the widgets weren't inside the Overview group widget!

If you click on the dashboard title, there is a description that drops down. There, you can copy-paste the text you have in the overview

Each group usually comes with a text box (or a note) giving a quick overview of its purpose, you can add those if you feel that they would be useful

Review from rtrieu is dismissed. Related teams and files:

documentation
- wlan/assets/dashboards/wlan_overview.json

Review from dkirov-dd is dismissed. Related teams and files:

agent-integrations
- wlan/assets/dashboards/wlan_overview.json

* initial scaffolding * Documentation first cut F * Update wlan/README.md Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com> * Added wlan.receive_rate metric to the specification * Added dashboard JSON and few other minor improvements * Added pre-requisite section to the README.md file * Update tile * Fixed manifest.json * Trying to fix failed CI * fix metadata.csv * fix manifest.json * regenerate manifest.json as normal integration * remove service_checks entry * fix manifest.json json format * remove monitors and saved views properties * fix extra comma in manifest.json * ddev validate labeler --sync * fix labeler config * Added monitor template * Fix JSON syntax issue from previous commit * Fix monitor JSON * update monitor title and description * Add macOS prerequisite * Documentation changes * Update wlan/README.md Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com> * Update wlan/README.md Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/README.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update wlan/assets/monitors/wlan_excessive_channel_swap.json Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update README.md * Apply suggestions from code review Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Fix github missing three-back ticks in suggestion * fix overview widgets grouping + add description * fix image logo link to use druids wlan logo --------- Co-authored-by: Len Gamburg <len.gamburg@datadoghq.com> Co-authored-by: Len Gamburg <98782554+iglendd@users.noreply.github.com> Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> 13b4af2

…cas.kretvix/rabbitmq-openmetrics-update * 'master' of github.com:DataDog/integrations-core: Port new ints releases for 7.67.x (#20300) Add WLAN integration tile (#19965) [RabbitMQ][DSM] Update rabbitmq management dashboard with new layout, include DSM metrics (#20275) Fix SQLServer changelog and add Agent version (#20294) fix metric name (#20281) SQLServer XE add missing event fields (#20293) Collect post job CPU and Memory efficiency from seff output (#20255) [OTELS-583] Fix DD connector & exporter graphs on OTel dashboard (#20277) Cisco ACI faults require NDM metadata to be enabled. (#20279)

initial scaffolding

d99ec76

datadog-agent-integrations-bot bot added documentation qa/skip-qa Automatically skip this PR for the next QA labels Mar 31, 2025

Documentation first cut

c5af059

F

NouemanKHAL commented Apr 4, 2025

View reviewed changes

wlan/README.md Outdated Show resolved Hide resolved

Update wlan/README.md

9af6898

Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com>

NouemanKHAL commented Apr 15, 2025

View reviewed changes

wlan/metadata.csv Outdated Show resolved Hide resolved

iglendd added 5 commits April 15, 2025 20:14

Added wlan.receive_rate metric to the specification

51d3c9a

Merge branch 'noueman/add-wlan-integration-tile' of github.com:DataDo…

c0905ae

…g/integrations-core into noueman/add-wlan-integration-tile

Added dashboard JSON and few other minor improvements

1c07120

Added pre-requisite section to the README.md file

43d8214

Update tile

5e03139

iglendd marked this pull request as ready for review April 29, 2025 00:37

iglendd requested review from a team as code owners April 29, 2025 00:37

iglendd added 2 commits April 28, 2025 20:43

Fixed manifest.json

7fbf86a

Trying to fix failed CI

db8a77b

datadog-agent-integrations-bot bot added team/agent-integrations team/documentation labels Apr 29, 2025

NouemanKHAL added 6 commits April 29, 2025 17:16

fix metadata.csv

c8a8927

fix manifest.json

52cccba

regenerate manifest.json as normal integration

0e5a74f

remove service_checks entry

36e65e5

fix manifest.json json format

50efb23

remove monitors and saved views properties

003a08a

aliciascott added the editorial review Waiting on a more in-depth review from a docs team editor label Apr 29, 2025

fix extra comma in manifest.json

c27d983

ddev validate labeler --sync

733b783

NouemanKHAL requested a review from a team as a code owner April 29, 2025 18:17

iglendd and others added 6 commits May 14, 2025 13:24

Update wlan/README.md

87b71e8

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

Update wlan/README.md

a251e35

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

Update wlan/README.md

263f851

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

Update wlan/README.md

d83185b

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

Update wlan/assets/monitors/wlan_excessive_channel_swap.json

f2617db

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

Update README.md

0dff9ff

iglendd requested a review from rtrieu May 14, 2025 17:29

rtrieu reviewed May 14, 2025

View reviewed changes

wlan/README.md Outdated Show resolved Hide resolved

rtrieu reviewed May 14, 2025

View reviewed changes

wlan/README.md Outdated Show resolved Hide resolved

rtrieu previously approved these changes May 14, 2025

View reviewed changes

NouemanKHAL commented May 14, 2025

View reviewed changes

wlan/README.md Outdated Show resolved Hide resolved

NouemanKHAL commented May 14, 2025

View reviewed changes

wlan/README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

cc437d6

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

NouemanKHAL commented May 14, 2025

View reviewed changes

wlan/README.md Show resolved Hide resolved

Fix github missing three-back ticks in suggestion

d5415ac

NouemanKHAL requested a review from rtrieu May 14, 2025 19:29

rtrieu previously approved these changes May 14, 2025

View reviewed changes

dkirov-dd previously approved these changes May 15, 2025

View reviewed changes

fix overview widgets grouping + add description

80857d5

fix image logo link to use druids wlan logo

f30e048

dkirov-dd approved these changes May 15, 2025

View reviewed changes

NouemanKHAL added this pull request to the merge queue May 15, 2025

Merged via the queue into master with commit 13b4af2 May 15, 2025
35 checks passed

NouemanKHAL deleted the noueman/add-wlan-integration-tile branch May 15, 2025 14:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add WLAN integration tile #19965

Add WLAN integration tile #19965

Uh oh!

NouemanKHAL commented Mar 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

aliciascott commented Apr 29, 2025

Uh oh!

Uh oh!

Uh oh!

rtrieu left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkirov-dd left a comment

Uh oh!

dkirov-dd May 15, 2025

Uh oh!

dkirov-dd May 15, 2025

Uh oh!

dkirov-dd May 15, 2025

Uh oh!

NouemanKHAL May 15, 2025

Uh oh!

dkirov-dd May 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Add WLAN integration tile #19965

Add WLAN integration tile #19965

Uh oh!

Conversation

NouemanKHAL commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

Uh oh!

Uh oh!

aliciascott commented Apr 29, 2025

Uh oh!

Uh oh!

Uh oh!

rtrieu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkirov-dd left a comment

Choose a reason for hiding this comment

Uh oh!

dkirov-dd May 15, 2025

Choose a reason for hiding this comment

Uh oh!

dkirov-dd May 15, 2025

Choose a reason for hiding this comment

Uh oh!

dkirov-dd May 15, 2025

Choose a reason for hiding this comment

Uh oh!

NouemanKHAL May 15, 2025

Choose a reason for hiding this comment

Uh oh!

dkirov-dd May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NouemanKHAL commented Mar 31, 2025 •

edited

Loading

dkirov-dd May 15, 2025 •

edited

Loading