Skip to content

Package Size Analyzer (AI-5021) #20128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 71 commits into from
May 22, 2025

Conversation

luciasanchezbella01
Copy link
Contributor

What does this PR do?

Adds new commands to ddev to track and analyze size changes in integrations and dependencies:

  • ddev size status: Shows current sizes of all modules.
  • ddev size diff [INITIAL_COMMIT] [FINAL_COMMIT]: Compares size changes between two commits.
  • ddev size timeline {integration | dependency} [INTEGRATION_NAME/DEPENDENCY_NAME]: Visualizes the size evolution of a module over time.

Motivation

The size of integrations and dependencies needs to be monitored to be able to keep it within acceptable limits.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@luciasanchezbella01 luciasanchezbella01 marked this pull request as ready for review May 19, 2025 13:00
@luciasanchezbella01 luciasanchezbella01 requested a review from a team as a code owner May 19, 2025 13:00
@luciasanchezbella01 luciasanchezbella01 marked this pull request as draft May 20, 2025 14:50
@luciasanchezbella01 luciasanchezbella01 marked this pull request as ready for review May 21, 2025 12:09
@luciasanchezbella01
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 22, 2025

View all feedbacks in Devflow UI.

2025-05-22 07:23:14 UTC ℹ️ Start processing command /merge


2025-05-22 07:23:25 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-22 08:46:24 UTC ⚠️ MergeQueue: This merge request was unqueued

lucia.sanchezbella@datadoghq.com unqueued this merge request

@luciasanchezbella01
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented May 22, 2025

View all feedbacks in Devflow UI.

2025-05-22 08:46:14 UTC ℹ️ Start processing command /remove


2025-05-22 08:46:17 UTC ℹ️ Devflow: /remove

@luciasanchezbella01 luciasanchezbella01 added this pull request to the merge queue May 22, 2025
Merged via the queue into master with commit 75f364d May 22, 2025
650 of 654 checks passed
@luciasanchezbella01 luciasanchezbella01 deleted the luciaSanchez/package_size_analyzer branch May 22, 2025 08:48
github-actions bot pushed a commit that referenced this pull request May 22, 2025
* basic status reporting

* integration into ddev

* clean commented code

* add diff mode

* add diff mode

* final diff version

* final diff version

* Added timeline mode and uncompressed sizes (#5025)

* Test ddev size status in GHA (by hijacking the slapr workflow)

* Timeline mode

* Try to fix job summaries

* Try fixing the job summaries again

* CI size status integration on master

* types added

* change --help

* fix

* fix typing

* fix typing

* fix types

* fix types

* fix typing

* fix typing

* fix typing

* fix typing

* fix tests for Windows

* Fix tests

* fix windows tests

* Fix tests

* Fix tests

* fix windows tests

* Final visualizations

* Changelog

* CI images integration and fixed typing

* user errors and dep and int versions

* user errors and dep and int versions

* user errors and dep and int versions

* fix timeline error

* Adding version, and json and markdown formats

* Fix test

* simplify code

* final fixes

* fix ddev windows

* fix lint

* testing ddev tests on windows

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* fixes

* test gha

* test gha

* test gha

* fixes

* fixes

* fix

* correct comments

* correct comments

* Change comments

* Change number to constant

* Fix a comment

* Rerun checks

* Fix versions

---------

Co-authored-by: Enrico Donnici <enrico.donnici@datadoghq.com> 75f364d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants