Skip to content

DDSaaS: Genesys: Updated Assets as per metric prefix #20162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

avaid-crest
Copy link
Contributor

What does this PR do?

  • In this pull request, the assets have been updated to reflect the change in the metric prefix from genesys to genesys_cloud.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@avaid-crest avaid-crest changed the title DDSaaS: Genesys: Updated Metric Prefix DDSaaS: Genesys: Updated Assets as per metric prefix Apr 28, 2025
@avaid-crest avaid-crest marked this pull request as ready for review April 28, 2025 12:24
@avaid-crest avaid-crest requested review from a team as code owners April 28, 2025 12:24
aliciascott
aliciascott previously approved these changes Apr 28, 2025
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for docs

Copy link

cit-pr-commenter bot commented Apr 29, 2025

PR Security Update

All commits in this PR up to and including 76aafc4 have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack.

Copy link
Contributor

@nathanmadams nathanmadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this... just the one comment about the check metrics.

"prefix": "genesys.",
"check": ["genesys.voice.total_conversations", "genesys.callback.wait_time_avg"],
"prefix": "genesys_cloud.",
"check": ["genesys_cloud.voice.total_conversations", "genesys_cloud.callback.wait_time_avg"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove these "check" metrics... reason being that these metrics are optional and can be disabled by the user (so indicating that there's a problem when they're missing is likely to be confusing.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nathanmadams, we tried removing the 'check' metrics, but the pipeline fails with the error.
The assets > integration > metrics > check field is required if metrics metadata is present.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the confusion... for now can you just add a metric from each "stream" to the list? That way, no matter which streams they enable, we'll recognize that they're getting data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nathanmadams, we've added a check metric for each stream.

apiazza-dd
apiazza-dd previously approved these changes May 9, 2025
Copy link
Contributor

@nathanmadams nathanmadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the check metric removal request an explicit change request so it's visible

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from aliciascott and apiazza-dd May 12, 2025 09:19

Review from aliciascott is dismissed. Related teams and files:

  • documentation
    • genesys/manifest.json

Review from apiazza-dd is dismissed. Related teams and files:

  • saas-integrations
    • genesys/manifest.json
@avaid-crest avaid-crest requested a review from nathanmadams May 13, 2025 13:41
@nathanmadams nathanmadams enabled auto-merge May 13, 2025 13:45
@nathanmadams nathanmadams added this pull request to the merge queue May 13, 2025
Merged via the queue into DataDog:master with commit 2148f75 May 13, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants