-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DDSaaS: Genesys: Updated Assets as per metric prefix #20162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDSaaS: Genesys: Updated Assets as per metric prefix #20162
Conversation
…into updated-assets-regarding-renamed-genesys-metric-prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for docs
PR Security UpdateAll commits in this PR up to and including 76aafc4 have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this... just the one comment about the check metrics.
genesys/manifest.json
Outdated
"prefix": "genesys.", | ||
"check": ["genesys.voice.total_conversations", "genesys.callback.wait_time_avg"], | ||
"prefix": "genesys_cloud.", | ||
"check": ["genesys_cloud.voice.total_conversations", "genesys_cloud.callback.wait_time_avg"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove these "check" metrics... reason being that these metrics are optional and can be disabled by the user (so indicating that there's a problem when they're missing is likely to be confusing.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nathanmadams, we tried removing the 'check' metrics, but the pipeline fails with the error.
The assets > integration > metrics > check field is required if metrics metadata is present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the confusion... for now can you just add a metric from each "stream" to the list? That way, no matter which streams they enable, we'll recognize that they're getting data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nathanmadams, we've added a check metric for each stream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the check metric removal request an explicit change request so it's visible
Review from aliciascott is dismissed. Related teams and files:
- documentation
- genesys/manifest.json
Review from apiazza-dd is dismissed. Related teams and files:
- saas-integrations
- genesys/manifest.json
…into updated-assets-regarding-renamed-genesys-metric-prefix
What does this PR do?
genesys
togenesys_cloud
.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged