SQLServer Extended Event Handlers #20229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azhou-datadog
changed the title
azhou-datadog
force-pushed
the
allen.zhou/sqlserver_xe_deobf
branch
from
550ae52 to
19a6803
Compare
sethsamuel
requested changes
May 9, 2025
| filtered_events = [] | ||
| try: | ||
| # Convert string to bytes for lxml | ||
| xml_stream = BytesIO(xml_data.encode('utf-8')) |
There was a problem hiding this comment.
Is the data returned always utf-8?
There was a problem hiding this comment.
So the raw data is taken at raw_xml = str(row[0]), which is already getting a properly decoded string. I just choose an encoding here to convert it to bytes for lxml parsing. Just in case though, I can add back up logic to encode in utf-16 if we hit encoding errors.
lu-zhengda
reviewed
May 12, 2025
Datadog Summary✅ Code Quality ✅ Code Security ❌ Dependencies Was this helpful? Give us feedback! |
1 task
sethsamuel
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the SQLServer Extended Event Handlers. This enables deobfuscation and query error visibility. This is a beefy PR so I will describe at a high level each component. See the RFC here
Configuration
XE Handler
Events emitted
Currently collects three types of query completion events, emitted as dbm_type=query_completion:
Collects two types of error events, emitted as dbm_type=query_error:
Emits RQT (Raw Query Text) events when collect_raw_query_statement.enabled is true:
Testing
Motivation
Get query error and deobfuscated query visibility for sqlserver. This is a targeted feature for Rockstar, but greatly strengthens DBM's sqlserver offering.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged