Skip to content

[RabbitMQ][DSM] Update rabbitmq management dashboard with new layout, include DSM metrics #20275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025

Conversation

lkretvix
Copy link
Contributor

@lkretvix lkretvix commented May 13, 2025

What does this PR do?

https://datadoghq.atlassian.net/browse/DSMON-747

Provide a data streaming pass on the rabbitmq (management) OOTB dashboard. As the team in charge of monitoring data streaming (DSM) we should have a good idea of what should be included here and help out with the management and curation of these dashboards

Current Integration dashboard: https://app.datadoghq.com/dash/integration/237/rabbitmq-overview-management-version

Example of the below changes (a copy + paste of the JSON so it's 1:1): https://dd.datad0g.com/dashboard/fyk-qzm-ji2?fromUser=false&refresh_mode=sliding&from_ts=1747152002828&to_ts=1747155602828&live=true

Updated and improved the dashboard to have:

  • Resource consumption and node info
  • Queue metrics (including DSM based data)
  • Exchange metrics

Motivation

Better Streaming OOTB dashboards, add knowledge (and, if instrumented, data) of our DSM product

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@lkretvix lkretvix force-pushed the lucas.krevix/rabbitmq-management-update branch from 99daa4c to 3d492e1 Compare May 13, 2025 17:05
@lkretvix lkretvix changed the title [DSM] Update rabbitmq management dashboard with new layout, include D… [RabbitMQ][DSM] Update rabbitmq management dashboard with new layout, include DSM metrics May 13, 2025
@lkretvix lkretvix marked this pull request as ready for review May 13, 2025 17:56
@lkretvix lkretvix requested review from a team as code owners May 13, 2025 17:56
drichards-87
drichards-87 previously approved these changes May 13, 2025
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions from Docs and approved the PR.

Copy link
Contributor

@robcarlan-datadog robcarlan-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about casing

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed drichards-87’s stale review May 13, 2025 21:41

Review from drichards-87 is dismissed. Related teams and files:

  • documentation
    • rabbitmq/assets/dashboards/rabbitmq_screenboard_dashboard.json
@lkretvix
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 14, 2025

View all feedbacks in Devflow UI.

2025-05-14 18:25:50 UTC ℹ️ Start processing command /merge


2025-05-14 18:25:56 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-14 22:26:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@Kyle-Neale Kyle-Neale added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit bb6eddd May 15, 2025
37 of 38 checks passed
@Kyle-Neale Kyle-Neale deleted the lucas.krevix/rabbitmq-management-update branch May 15, 2025 13:16
lkretvix added a commit that referenced this pull request May 15, 2025
…cas.kretvix/rabbitmq-openmetrics-update

* 'master' of github.com:DataDog/integrations-core:
  Port new ints releases for 7.67.x (#20300)
  Add WLAN integration tile (#19965)
  [RabbitMQ][DSM] Update rabbitmq management dashboard with new layout, include DSM metrics (#20275)
  Fix SQLServer changelog and add Agent version (#20294)
  fix metric name (#20281)
  SQLServer XE add missing event fields (#20293)
  Collect post job CPU and Memory efficiency from seff output (#20255)
  [OTELS-583] Fix DD connector & exporter graphs on OTel dashboard (#20277)
  Cisco ACI faults require NDM metadata to be enabled. (#20279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants