Skip to content

Ensure ddev release tag fetches tags before getting the full list #20292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented May 14, 2025

What does this PR do?

This PR modifies the current behavior of the ddev release tag by first fetching the list of tags. This is to ensure that when the full list of tag is going to be compared against current versions we have the most up to date version in origin.

In order for this to work in integrations-core-pipeline we need to update the tagger image after datadog-checks-dev newer version has been released with an updated dependency in ddev with this package. While this is not done (comming in a future PR) this change won't have any effect in the pipeline. The reason is that we are building ddev with the build package which ignores the local linking done by hatch in environments locally.

I also added an option to the gitlab file to manually trigger the tagger and image log integrations validations images. If we keep the ddev dependency as it is now, patch updates on the datadog-checks-dev package won't trigger a build since there is no change in the ddev dependency list.

Motivation

Ensure all tags are available when running ddev release tag.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe requested a review from a team as a code owner May 14, 2025 13:47
@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label May 14, 2025
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (88af1c4) to head (76d1b3d).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
datadog_checks_dev 77.64% <100.00%> (+0.06%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AAraKKe AAraKKe enabled auto-merge May 23, 2025 12:32
@AAraKKe AAraKKe added this pull request to the merge queue May 23, 2025
Merged via the queue into master with commit c0e94d6 May 23, 2025
27 checks passed
@AAraKKe AAraKKe deleted the aarakke/ensure-tags-are-fetched-before-list branch May 23, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants