Fix object name field in rpc query_completion events and activity_id fields for error events

[azhou-datadog]

What does this PR do?

Fix object name field in rpc query_completion events. I was incorrectly using the field name of "procedure_name" when it is actually "object_name". Line number, object_id, and spills was also added from module_end but is not exposed in rpc events, so removed that field.

Also added activity_id_xfer field for all event types, which I discovered shows up in error events. Haven't seen it appear in query completion events, but adding it defensively.

"query_details": {
        "xe_type": "rpc_completed",
        "event_fire_timestamp": "2025-05-15T16:24:31.745Z",
        "query_start": "2025-05-15T16:24:28.435Z",
        "duration_ms": 3309.829,
        "session_id": 53,
        "request_id": 0,
        "cpu_time": 1671000,
        "page_server_reads": 0,
        "physical_reads": 0,
        "logical_reads": 5159,
        "writes": 229,
        "row_count": 1,
        "database_name": "master",
        "client_hostname": "ip-172-29-202-71",
        "client_app_name": "agent",
        "username": "datadog",
        "activity_id": "190B14E0-40D2-4617-9DC7-0A5B0B8BD6E1-3",
        "result": "OK",
        "object_name": "sp_prepexec",
        "data_stream": "",
        "connection_reset_option": "0",
        "statement": "declare @p1 int set @p1 = ? exec sp_prepexec @p1 output, N ?, N ? ? ? ? ?, N ? select @p1",
        "sql_text": ") SELECT CAST ( t.target_data AS XML ) AS target_xml FROM sys.dm_xe_sessions s JOIN sys.dm_xe_session_targets t ON s.address = t.event_session_address WHERE s.name = @P1 AND t.target_name = ?",
        "query_signature": "e0aece8e6d583f83",
        "raw_query_signature": "96c35cf452b7c2b3"
      }

Motivation

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
• If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (a90006e) to head (564701f).
Report is 16 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
activemq	?
cassandra	?
confluent_platform	?
hive	?
hivemq	?
hudi	?
ignite	?
jboss_wildfly	?
kafka	?
presto	?
solr	?
sqlserver	91.17% <94.11%> (+4.69%)	⬆️
tomcat	?
weblogic	?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[azhou-datadog]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.

2025-05-15 19:09:37 UTC ℹ️ Start processing command /merge

---

2025-05-15 19:09:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2025-05-15 23:10:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Review from lu-zhengda is dismissed. Related teams and files:

• database-monitoring-agent
  • sqlserver/changelog.d/20302.fixed
  • sqlserver/datadog_checks/sqlserver/xe_collection/base.py
  • sqlserver/datadog_checks/sqlserver/xe_collection/error_events.py
  • sqlserver/datadog_checks/sqlserver/xe_collection/query_completion_events.py
  • sqlserver/tests/test_xe_collection.py
  • sqlserver/tests/xml_xe_events/attention.xml
  • sqlserver/tests/xml_xe_events/error_reported.xml