Skip to content

Package Size Analyzer Improvements (AI-5309) #20330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 117 commits into from
May 27, 2025
Merged

Package Size Analyzer Improvements (AI-5309) #20330

merged 117 commits into from
May 27, 2025

Conversation

luciasanchezbella01
Copy link
Contributor

What does this PR do?

Adds new features to the ddev size command:

  • Adds a new flag -send-metrics-dd-org in ddev size status to send metrics to Datadog.
  • Adds a new create-dashboard command to automatically create a dashboard in Datadog with those metrics.

Motivation

To provide an easier way to track and visualize size metrics.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

luciasanchezbella01 and others added 30 commits March 12, 2025 12:52
@luciasanchezbella01
basic status reporting
c39ed1a
@luciasanchezbella01
integration into ddev
a9c824d
@luciasanchezbella01
clean commented code
b4d0f5f
@luciasanchezbella01
add diff mode
79b0fa8
@luciasanchezbella01
add diff mode
fefd6a3
@luciasanchezbella01
final diff version
76c1f09
@luciasanchezbella01
final diff version
5aa1f49
@luciasanchezbella01
Added timeline mode and uncompressed sizes (#5025)
c64d2f9
@nubtron
Test ddev size status in GHA (by hijacking the slapr workflow)
846886d
@luciasanchezbella01
Timeline mode
a3aafc5
@nubtron
Merge remote-tracking branch 'origin/luciaSanchez/package_size_analyz…
09c7a05 
…er' into luciaSanchez-nubtron/package-size-analyzer-gha-experiments
@nubtron
Try to fix job summaries
5a4e5d3
@nubtron
Try fixing the job summaries again
a4a00dd
@luciasanchezbella01
CI size status integration on master
ed1e372
@luciasanchezbella01
types added
9cc7e5b
@luciasanchezbella01
change --help
0f7b09c
@luciasanchezbella01
fix
7064fd9
@luciasanchezbella01
fix typing
8cc7710
@luciasanchezbella01
fix typing
f1711cc
@luciasanchezbella01
fix types
b33a1fd
@luciasanchezbella01
fix types
f16938b
@luciasanchezbella01
fix typing
4d2c8e9
@luciasanchezbella01
fix typing
3d6a228
@luciasanchezbella01
fix typing
d97854b
@luciasanchezbella01
fix typing
f713097
@luciasanchezbella01
fix tests for Windows
0d750b3
@luciasanchezbella01
Fix tests
06a2b5f
@luciasanchezbella01
fix windows tests
63137be
@luciasanchezbella01
Fix tests
1791728
@luciasanchezbella01
Fix tests
c232868
@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

nubtron
nubtron previously approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@nubtron nubtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note about the dashboard command help text, otherwise looks good! Approving in the meantime!

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nubtron’s stale review May 27, 2025 08:54

Review from nubtron is dismissed. Related teams and files:

  • agent-integrations
    • ddev/src/ddev/cli/size/create_dashboard.py
@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@luciasanchezbella01 luciasanchezbella01 marked this pull request as ready for review May 27, 2025 14:46
@luciasanchezbella01 luciasanchezbella01 requested a review from a team as a code owner May 27, 2025 14:46
@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@luciasanchezbella01 luciasanchezbella01 added this pull request to the merge queue May 27, 2025
Merged via the queue into master with commit 6878f62 May 27, 2025
654 of 656 checks passed
@luciasanchezbella01 luciasanchezbella01 deleted the lucia/package_size_analyzer_improvements branch May 27, 2025 14:48
github-actions bot pushed a commit that referenced this pull request May 27, 2025
@github-merge-queue
Package Size Analyzer Improvements (AI-5309) (#20330)
7dcf4f6 
* basic status reporting

* integration into ddev

* clean commented code

* add diff mode

* add diff mode

* final diff version

* final diff version

* Added timeline mode and uncompressed sizes (#5025)

* Test ddev size status in GHA (by hijacking the slapr workflow)

* Timeline mode

* Try to fix job summaries

* Try fixing the job summaries again

* CI size status integration on master

* types added

* change --help

* fix

* fix typing

* fix typing

* fix types

* fix types

* fix typing

* fix typing

* fix typing

* fix typing

* fix tests for Windows

* Fix tests

* fix windows tests

* Fix tests

* Fix tests

* fix windows tests

* Final visualizations

* Changelog

* CI images integration and fixed typing

* user errors and dep and int versions

* user errors and dep and int versions

* user errors and dep and int versions

* fix timeline error

* Adding version, and json and markdown formats

* Fix test

* simplify code

* final fixes

* fix ddev windows

* fix lint

* testing ddev tests on windows

* initialize create_dashboard command

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* send metrics to dd

* create-dashboard command

* fixes

* test gha

* test gha

* test gha

* fixes

* fixes

* fixes

* fix

* getting commit timestamp

* getting commit timestamp

* Add commit timestamp

* correct comments

* correct comments

* Change comments

* Change number to constant

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Fix a comment

* Change number to constant

* Typing

* Change format flags

* change format input

* Correct test-common

* wip: Work in Progress

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Fix typing

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Lints

* Fix tests

* Changelog

* Change create-dashboard help

* Simplify output formats

---------

Co-authored-by: Enrico Donnici <enrico.donnici@datadoghq.com> 6878f62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nubtron nubtron nubtron approved these changes

Assignees
No one assigned
Labels
ddev dev/testing dev/tooling team/agent-integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luciasanchezbella01 @nubtron