Skip to content

fix invalid code blocks #20401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

bgoldberg122
Copy link
Contributor

@bgoldberg122 bgoldberg122 commented May 28, 2025

What does this PR do?

These markdown tags fail the docs validator and break the docs site. The docs validator will start to be blocking.

Motivation

These code tags fail the docs validator and break the docs site. The docs validator will start to be blocking.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@bgoldberg122 bgoldberg122 force-pushed the bgoldberg122/IDP-474_fix-invalid-docs-readmes branch from 866053f to 6f0e5f1 Compare May 28, 2025 19:27
@buraizu buraizu self-assigned this May 28, 2025
@buraizu buraizu added the editorial review Waiting on a more in-depth review from a docs team editor label May 28, 2025
@buraizu
Copy link
Contributor

buraizu commented May 28, 2025

Noticed an issue with this change not being fully propagated in a local build of the documentation site. Created DOCS-11066 to follow up.

@buraizu buraizu removed their assignment May 28, 2025
@hestonhoffman hestonhoffman self-assigned this May 29, 2025
sarah-witt
sarah-witt previously approved these changes May 29, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed sarah-witt’s stale review May 29, 2025 17:37

Review from sarah-witt is dismissed. Related teams and files:

  • agent-integrations
    • kube_apiserver_metrics/README.md
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed up a fix for the tabs

@bgoldberg122 bgoldberg122 added this pull request to the merge queue May 29, 2025
Merged via the queue into master with commit 18d0ecc May 29, 2025
66 of 70 checks passed
@bgoldberg122 bgoldberg122 deleted the bgoldberg122/IDP-474_fix-invalid-docs-readmes branch May 29, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants