Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in README #458

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix link in README #458

merged 1 commit into from
Jan 16, 2024

Conversation

stanleegoodspeed
Copy link
Contributor

@stanleegoodspeed stanleegoodspeed commented Jan 16, 2024

What does this PR do?

This removes the french page prefix/fr from the ASM directions

Motivation

I noticed this when going through the enabledASM instructions on the docs site and I was redirected to the french translation site https://docs.datadoghq.com/serverless/libraries_integrations/plugin/

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@stanleegoodspeed stanleegoodspeed requested a review from a team as a code owner January 16, 2024 16:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78f2eb9) 76.33% compared to head (20dc141) 76.33%.

❗ Current head 20dc141 differs from pull request most recent head a5a7a28. Consider uploading reports for the commit a5a7a28 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   76.33%   76.33%           
=======================================
  Files          12       12           
  Lines         955      955           
  Branches      299      299           
=======================================
  Hits          729      729           
  Misses        164      164           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@purple4reina purple4reina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@purple4reina purple4reina merged commit b1b672a into DataDog:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants