-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEBUG-3483] add: tests for probe budgets #3910
base: main
Are you sure you want to change the base?
Conversation
825b521
to
2f52816
Compare
1264468
to
76183ee
Compare
76183ee
to
9e789dd
Compare
@shurivich This is ready for review, there's some issues with the trigger probes for both Python and Java so that's currently disabled for all languages, but I'll re-enable when the problems are enabled. For now it gives us a rough idea that standard rate-limiting for enriched snapshots are working within a threshold. |
70cb56c
to
f4eb484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing on CI (failure on java build step are not related, you can rebase your branch to fix them)
e3f59b7
to
97e8ca5
Compare
fix: generalize line mapping and add java test fix: filter non-spring-boot weblogs fix: add session_id tag to get correct budgets add: link to feature-parity dashboard fix: check captures instead of presence of snapshot only
97e8ca5
to
b4dfb8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some small comments.
Motivation
This pull request includes several changes to the debugger tests and utilities, focusing on method refactoring, adding new test probes, and enhancing test coverage for probe budgets. The most important changes include adding new probe definitions, refactoring method calls, and updating test setup and validation logic.
Changes
tests/debugger/probes/probe_log_method_budgets.json
andtests/debugger/probes/probe_snapshot_log_line_budgets.json
to support logging and snapshot capturing for budget-related tests. [1] [2]_setup
method intests/debugger/test_debugger_probe_snapshot.py
to include timing logic and line probe setup.tests/debugger/test_debugger_probe_snapshot.py
.method_and_language_to_line_number
intests/debugger/utils.py
to centralize line number mappings./budgets/{loops}
inutils/build/docker/java/spring-boot/src/main/java/com/datadoghq/system_tests/springboot/debugger/DebuggerController.java
andutils/build/docker/python/flask/debugger_controller.py
for budget-related tests. [1] [2]debugger_probe_budgets
inutils/_features.py
to manage probe budget tests.Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present