chore(parametric): validate telemetry schema #4076
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
force-pushed
the
dmehala/parametric-telemetry-validation
branch
2 times, most recently
from
af09854 to
0a25ba9
Compare
This commit add telemetry schema validation for parametric tests. Changes: - Update test to enforce values for configuration telemetry. - Disable some tests for golang and nodejs.
dmehala
force-pushed
the
dmehala/parametric-telemetry-validation
branch
from
0a25ba9 to
b81bab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While investigating invalid telemetry payloads for C++ and decided to solve the issue with [this PR], I decided to go the extra mile. Since I wasn't confident in my ability to assess whether telemetry payload generate by the tracer conforms to the telemetry schema, I decided to implement a validation step for system-tests using jsonschema.
Fortunately, the talented engineers at ASM had already written the schemas, which greatly helped in this process.
Changes
TelemetryV2Validatorclass to validate telemetry v2 schema.parametric/test_telemetry.pytests suite to integrate the validator.