Skip to content

Make X_original constant #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Banana1530 opened this issue Aug 23, 2019 · 1 comment
Open

Make X_original constant #61

Banana1530 opened this issue Aug 23, 2019 · 1 comment
Assignees
Labels
Algorithm Improvements Improvements to core MoMA Algorithm Code Cleanliness Internal changes / clean-ups / refactoring

Comments

@Banana1530
Copy link
Collaborator

Any reason these are non-const?

Originally posted by @michaelweylandt in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3Mjc4MDgzMjQ0/pull_request_reviews/more_threads

@Banana1530
Copy link
Collaborator Author

Banana1530 commented Aug 23, 2019

The follow code snippet should explain the semantics of these seemingly confusing variables.

class MoMA
{
  private:
    // ......
    arma::mat X;          // on X we perform the algorithm

    arma::mat X_working;  // keep track of deflated matrices
    arma::mat Y_working;

    arma::mat X_original;  // const
    arma::mat Y_original;
}

@Banana1530 Banana1530 reopened this Aug 23, 2019
@michaelweylandt michaelweylandt added Algorithm Improvements Improvements to core MoMA Algorithm Code Cleanliness Internal changes / clean-ups / refactoring labels Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algorithm Improvements Improvements to core MoMA Algorithm Code Cleanliness Internal changes / clean-ups / refactoring
Projects
None yet
Development

No branches or pull requests

2 participants