Skip to content

Commit 6dc2bb2

Browse files
committed
[DH-5756] Raise an error when sql is not valid
1 parent 6a3df95 commit 6dc2bb2

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

Diff for: dataherald/api/types/requests.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
from pydantic import BaseModel
1+
from pydantic import BaseModel, validator
2+
from sql_metadata import Parser
23

34
from dataherald.types import LLMConfig
45

@@ -17,6 +18,14 @@ class SQLGenerationRequest(BaseModel):
1718
sql: str | None
1819
metadata: dict | None
1920

21+
@validator("sql")
22+
def validate_model_name(cls, v: str | None):
23+
try:
24+
Parser(v).tables # noqa: B018
25+
except Exception as e:
26+
raise ValueError(f"SQL {v} is malformed. Please check the syntax.") from e
27+
return v
28+
2029

2130
class StreamSQLGenerationRequest(BaseModel):
2231
finetuning_id: str | None

0 commit comments

Comments
 (0)