Skip to content

[DH-5756] Raise an error when sql is not valid #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[DH-5756] Raise an error when sql is not valid #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dataherald/api/types/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from pydantic import BaseModel
from pydantic import BaseModel, validator
from sql_metadata import Parser

from dataherald.types import LLMConfig

Expand All @@ -17,6 +18,14 @@ class SQLGenerationRequest(BaseModel):
sql: str | None
metadata: dict | None

@validator("sql")
def validate_model_name(cls, v: str | None):
try:
Parser(v).tables # noqa: B018
except Exception as e:
raise ValueError(f"SQL {v} is malformed. Please check the syntax.") from e
return v


class StreamSQLGenerationRequest(BaseModel):
finetuning_id: str | None
Expand Down
Loading