Skip to content

Commit 506dd4d

Browse files
authored
Use dataset to access CSV Settings (#963)
According to jQuery's data implementation, this should be a backward-compatible change Ref: - https://github.com/jquery/jquery/blob/f79d5f1a337528940ab7029d4f8bbba72326f269/src/data.js#L42-L44 - https://api.jquery.com/data/#data-html5
1 parent 5dcb4ac commit 506dd4d

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

dist/client-side-validations.esm.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ var ClientSideValidations = {
123123
form: function form(_form2) {
124124
var $form = jQuery(_form2);
125125
_form2.ClientSideValidations = {
126-
settings: $form.data('clientSideValidations'),
126+
settings: JSON.parse(_form2.dataset.clientSideValidations),
127127
addError: function addError($element, message) {
128128
return ClientSideValidations.formBuilders[_form2.ClientSideValidations.settings.html_settings.type].add($element, _form2.ClientSideValidations.settings.html_settings, message);
129129
},

dist/client-side-validations.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
form: function form(_form2) {
128128
var $form = jQuery(_form2);
129129
_form2.ClientSideValidations = {
130-
settings: $form.data('clientSideValidations'),
130+
settings: JSON.parse(_form2.dataset.clientSideValidations),
131131
addError: function addError($element, message) {
132132
return ClientSideValidations.formBuilders[_form2.ClientSideValidations.settings.html_settings.type].add($element, _form2.ClientSideValidations.settings.html_settings, message);
133133
},

src/core.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const ClientSideValidations = {
8484
const $form = jQuery(form)
8585

8686
form.ClientSideValidations = {
87-
settings: $form.data('clientSideValidations'),
87+
settings: JSON.parse(form.dataset.clientSideValidations),
8888
addError: ($element, message) => ClientSideValidations
8989
.formBuilders[form.ClientSideValidations.settings.html_settings.type]
9090
.add($element, form.ClientSideValidations.settings.html_settings, message),

vendor/assets/javascripts/rails.validations.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
form: function form(_form2) {
128128
var $form = jQuery(_form2);
129129
_form2.ClientSideValidations = {
130-
settings: $form.data('clientSideValidations'),
130+
settings: JSON.parse(_form2.dataset.clientSideValidations),
131131
addError: function addError($element, message) {
132132
return ClientSideValidations.formBuilders[_form2.ClientSideValidations.settings.html_settings.type].add($element, _form2.ClientSideValidations.settings.html_settings, message);
133133
},

0 commit comments

Comments
 (0)