Skip to content

Commit fa2bbd2

Browse files
committed
Remove some jQuery from executeAllValidators
`element.dataset` and `$element.data` are not the same thing
1 parent 8c6fe71 commit fa2bbd2

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

dist/client-side-validations.esm.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,8 @@ var isMarkedForDestroy = function isMarkedForDestroy($element) {
673673
return false;
674674
};
675675
var executeAllValidators = function executeAllValidators($element, validators) {
676-
if ($element.data('changed') === false || $element.prop('disabled')) {
676+
var element = $element[0];
677+
if ($element.data('changed') === false || element.disabled) {
677678
return;
678679
}
679680
$element.data('changed', false);

dist/client-side-validations.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,8 @@
677677
return false;
678678
};
679679
var executeAllValidators = function executeAllValidators($element, validators) {
680-
if ($element.data('changed') === false || $element.prop('disabled')) {
680+
var element = $element[0];
681+
if ($element.data('changed') === false || element.disabled) {
681682
return;
682683
}
683684
$element.data('changed', false);

src/index.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ const isMarkedForDestroy = ($element) => {
184184
}
185185

186186
const executeAllValidators = ($element, validators) => {
187-
if ($element.data('changed') === false || $element.prop('disabled')) {
187+
const element = $element[0]
188+
if ($element.data('changed') === false || element.disabled) {
188189
return
189190
}
190191

vendor/assets/javascripts/rails.validations.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,8 @@
677677
return false;
678678
};
679679
var executeAllValidators = function executeAllValidators($element, validators) {
680-
if ($element.data('changed') === false || $element.prop('disabled')) {
680+
var element = $element[0];
681+
if ($element.data('changed') === false || element.disabled) {
681682
return;
682683
}
683684
$element.data('changed', false);

0 commit comments

Comments
 (0)