Skip to content

Commit 03421c0

Browse files
lgrateaulgrateau
authored
Merge pull request #9 from DecisionsDev/businessvalueeditor95
DBACLD-160990 - validate instructions for ODM 95
2 parents 95924ea + 8b4fa87 commit 03421c0

File tree

5 files changed

+31
-19
lines changed

5 files changed

+31
-19
lines changed

‎decisioncenter/businessvalueeditor/README-KUBERNETES.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,22 @@ Any file server reachable by Decision Center is suitable.
1212
You can either use an existing one or follow the instructions [here](https://github.com/DecisionsDev/odm-docker-kubernetes/blob/vnext-release/contrib/file-server/README.md#setup-an-httpd-file-server) to deploy a httpd file server in a new pod.
1313

1414
Upload the **businessvalueeditor-1.0.zip** file on the file server :
15-
```
15+
```bash
1616
curl -T businessvalueeditor/businessvalueeditor-source/target/businessvalueeditor-1.0.zip $FILESERVER_URL
1717
```
1818

19+
If all goes well, you should have an output with `201` status that the zip resource is created:
20+
```
21+
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
22+
<html>
23+
<head>
24+
<title>201 Created</title>
25+
</head><body>
26+
<h1>Created</h1>
27+
<p>Resource /businessvalueeditor-1.0.zip has been created.</p>
28+
</body></html>
29+
```
30+
1931
## 2. Deploying ODM
2032

2133
To get access to the ODM material, you must have an IBM entitlement key to pull the images from the IBM Cloud Container registry.
@@ -57,7 +69,7 @@ helm repo update
5769
```bash
5870
$ helm search repo ibm-odm-prod
5971
NAME CHART VERSION APP VERSION DESCRIPTION
60-
ibm-helm/ibm-odm-prod 24.0.1 9.0.0.1 IBM Operational Decision Manager
72+
ibm-helm/ibm-odm-prod 25.0.0 9.5.0.0 IBM Operational Decision Manager
6173
```
6274
#### e. Install an IBM Operational Decision Manager release
6375

‎decisioncenter/businessvalueeditor/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,24 +47,23 @@ To use the sample in Decision Center, you need to build a JAR for [Docker](READM
4747

4848
2. Build the JAR
4949

50-
The instructions below enable to build the JAR using a Docker container featuring Maven and a JDK version 17.
50+
The instructions below allow you to build the JAR using a Docker container featuring Maven and a JDK version 21, compatible for ODM 9.5.
5151

52-
For ODM 8.12, you must use **maven:3.8.1-openjdk-11** instead and **maven:3.8-adoptopenjdk-8** for earlier releases.
53-
54-
Run the command below in the **decisioncenter/businessvalueeditor/businessvalueeditor-source** directory:
52+
Run the command in the **decisioncenter/businessvalueeditor/businessvalueeditor-source** directory:
5553

5654
```bash
5755
docker run --rm \
5856
-v "$(pwd)":/usr/src/sample \
5957
-w /usr/src/sample \
60-
maven:3.8.5-openjdk-17 \
58+
maven:3.9.9-ibm-semeru-21-jammy \
6159
mvn clean install
6260
```
6361

6462
The JAR that will be used on [Docker](README-DOCKER.md) is generated in the **target** directory and is named **businessvalueeditor-1.0.jar**.
6563

6664
The ZIP that will be used on [Kubernetes](README-KUBERNETES.md) is generated in the **target** directory and is named **businessvalueeditor-1.0.zip**.
6765

66+
6867
### 3) Instructions to use the sample in Decision Center
6968

7069
Click one of the links below:

‎decisioncenter/businessvalueeditor/businessvalueeditor-source/compose-odm-dev.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
services:
22
odm:
3-
image: icr.io/cpopen/odm-k8s/odm:9.0.0
3+
image: icr.io/cpopen/odm-k8s/odm:9.5
44
mem_limit: 4G
55
memswap_limit: 4G
66
user: "1001:0"
@@ -12,7 +12,7 @@ services:
1212
- 9453:9453
1313

1414
odm-with-custom-value-editor:
15-
image: icr.io/cpopen/odm-k8s/odm:9.0.0
15+
image: icr.io/cpopen/odm-k8s/odm:9.5
1616
mem_limit: 4G
1717
memswap_limit: 4G
1818
user: "1001:0"

‎decisioncenter/businessvalueeditor/businessvalueeditor-source/pom.xml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,16 @@
2121
<goal>run</goal>
2222
</goals>
2323
<configuration>
24-
<tasks>
25-
<javac srcdir="${project.build.sourceDirectory}"
24+
<target>
25+
<javac srcdir="${project.build.sourceDirectory}"
2626
destdir="${project.build.outputDirectory}"
2727
includeantruntime="false"
2828
compiler="modern">
2929
<classpath>
3030
<fileset dir="${project.basedir}/lib" includes="**/*.jar"/>
3131
</classpath>
3232
</javac>
33-
</tasks>
33+
</target>
3434
</configuration>
3535
</execution>
3636
<execution>
@@ -40,12 +40,12 @@
4040
<goal>run</goal>
4141
</goals>
4242
<configuration>
43-
<tasks>
43+
<target>
4444
<zip destfile="${project.basedir}/target/businessvalueeditor-1.0.zip">
4545
<fileset dir="${project.basedir}/target" includes="businessvalueeditor-1.0.jar" />
4646
<fileset dir="${project.basedir}" includes="web.xml" />
4747
</zip>
48-
</tasks>
48+
</target>
4949
</configuration>
5050
</execution>
5151
</executions>
@@ -54,6 +54,7 @@
5454
<plugin>
5555
<groupId>org.apache.maven.plugins</groupId>
5656
<artifactId>maven-compiler-plugin</artifactId>
57+
<version>3.14.0</version>
5758
<executions>
5859
<execution>
5960
<id>default-compile</id>

‎decisioncenter/businessvalueeditor/businessvalueeditor-source/src/main/java/businessvalueeditor/SampleValueEditorServlet.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515
import ilog.rules.brl.value.descriptor.IlrValueDescriptorFactory;
1616
import ilog.rules.vocabulary.model.IlrConcept;
1717
import ilog.rules.vocabulary.model.IlrVocabulary;
18+
//ODM 9.5 onwards
19+
import jakarta.servlet.ServletException;
20+
import jakarta.servlet.http.HttpServlet;
21+
import jakarta.servlet.http.HttpServletRequest;
22+
import jakarta.servlet.http.HttpServletResponse;
1823

1924
import java.io.IOException;
2025
import java.util.Locale;
2126

22-
import javax.servlet.ServletException;
23-
import javax.servlet.http.HttpServlet;
24-
import javax.servlet.http.HttpServletRequest;
25-
import javax.servlet.http.HttpServletResponse;
26-
2727
import com.ibm.bdsl.web.editor.IntelliTextEditorEnvironment;
2828
import com.ibm.json.java.JSONArray;
2929
import com.ibm.json.java.JSONObject;

0 commit comments

Comments
 (0)