DBACLD-160994 - review the webhook sample

Author: Frederic Mercier

decisioncenter/webhooknotifier/README-DOCKER.md

@@ -19,7 +19,7 @@ Before following the steps below, make sure you have built the images as explain
    1. For the File Notifier:
    ```shell
     curl -X 'PUT' \
-    'http://localhost:9060/decisioncenter-api/v1/webhook/notify?url=http%3A%2F%2Flogifle%3A3000%2Fprint' \
+    'http://localhost:9060/decisioncenter-api/v1/webhook/notify?url=http%3A%2F%2Flogfile%3A3000%2Fprint' \
     -H 'accept: */*' \
     -H 'Content-Type: application/json' \
     -d 'null' \

decisioncenter/webhooknotifier/README-KUBERNETES.md

@@ -67,7 +67,7 @@ Also, before following the steps below, make sure you have built the images as e
 
      ```shell
      curl -k -X 'PUT' \
-     'https://$DC_HOST/decisioncenter-api/v1/webhook/notify?url=http%3A%2F%2Fwebhooknotifier-logfile.$NAMESPACE.svc.cluster.local%3A3000%2Fprint' \
+     "https://$DC_HOST/decisioncenter-api/v1/webhook/notify?url=http%3A%2F%2Fwebhooknotifier-logfile.$NAMESPACE.svc.cluster.local%3A3000%2Fprint" \
      -H 'accept: */*' \
      -H 'Content-Type: application/json' \
      -d 'null' \
@@ -85,7 +85,7 @@ Also, before following the steps below, make sure you have built the images as e
      export SLACK_TOKEN=`kubectl exec -ti webhooknotifier-slack -- curl 'http://localhost:3000/token.generate' -H 'accept: */*' -H 'Content-Type: application/json'`
 
      curl -X 'PUT' -k \
-     'https://$DC_HOST/decisioncenter-api/v1/webhook/notify?url=http%3A%2F%2Fwebhooknotifier-slack.$NAMESPACE.svc.cluster.local%3A3000%2Fslack' \
+     "https://$DC_HOST/decisioncenter-api/v1/webhook/notify?url=http%3A%2F%2Fwebhooknotifier-slack.$NAMESPACE.svc.cluster.local%3A3000%2Fslack" \
      -H 'accept: */*' \
      -H 'Content-Type: application/json' \
      -d "$SLACK_TOKEN" \
@@ -130,7 +130,7 @@ After creating this snapshot, a notification will be triggered.
 To view the content of the generated log file, run the following command:
 
 ```shell
-kubectl exec -ti <webhooknotifier-logfile-container-id> sh -c 'cat /app/results/default.txt'
+kubectl exec -ti <webhooknotifier-logfile-container-id> -- sh -c 'cat /app/results/default.txt'
 ```
 
 
@@ -218,9 +218,10 @@ and a message should appear your slack channel :
 To remove the webhooks configured in Decision Center, first list them:
 
 ```bash
-curl -X 'GET' \
-  'https://$DC_HOST/decisioncenter-api/v1/webhooks/notify' \
-  -H 'accept: */*'
+curl -k -X 'GET' \
+  "https://$DC_HOST/decisioncenter-api/v1/webhooks/notify" \
+  -H 'accept: */*' \
+  -u odmAdmin:odmAdmin
 ```
 
 where `$DC_HOST` should be set to the hostname of Decision Center.
@@ -241,9 +242,10 @@ The expected output looks like:
 You can then remove a webhook from Decision Center, by running the command below:
 
 ```bash
-curl -X 'DELETE' \
-  'https://$DC_HOST/decisioncenter-api/v1/webhooks/$WEBHOOK_ID/notify' \
-  -H 'accept: */*'
+curl -k -X 'DELETE' \
+  "https://$DC_HOST/decisioncenter-api/v1/webhooks/$WEBHOOK_ID/notify" \
+  -H 'accept: */*' \
+  -u odmAdmin:odmAdmin
 ```
 
 where

decisioncenter/webhooknotifier/README.md

@@ -35,7 +35,12 @@ This NodeJS sample code will be packaged in two docker images.
         ```bash
         docker-compose build
         ```
-> Note: The docker-compose build command will produce images based on your local machine’s architecture. If you plan to deploy this sample on a Kubernetes cluster, ensure the target environment uses the same architecture (e.g., x86_64 vs. arm64) to avoid compatibility issues. You may also need to specify a platform explicitly if building for a different architecture.
+
+> Note: The docker-compose build command will produce images based on your local machine’s architecture. If you plan to deploy this sample on a Kubernetes cluster, ensure the target environment uses the same architecture (e.g., amd64 vs. arm64) to avoid compatibility issues. You may also need to specify a platform explicitly if building for a different architecture.
+> For instance, you can make sure that the images are built for the `amd64` architecture by running:
+```bash
+docker-compose build -f docker-compose-amd64.yaml
+```
 
 ### Run the sample
 

decisioncenter/webhooknotifier/compose-odm-dev.yml

@@ -1,6 +1,6 @@
 services:
   odm:
-    image: icr.io/cpopen/odm-k8s/odm:9.0.0
+    image: icr.io/cpopen/odm-k8s/odm:9.5
     mem_limit: 4G
     memswap_limit: 4G
     user: "1001:0"

decisioncenter/webhooknotifier/docker-compose-amd64.yaml

@@ -0,0 +1,28 @@
+# Comments are provided throughout this file to help you get started.
+# If you need more help, visit the Docker Compose reference guide at
+# https://docs.docker.com/go/compose-spec-reference/
+
+# Here the instructions define your application as a service called "server".
+# This service is built from the Dockerfile in the current directory.
+# You can add other services your application may depend on here, such as a
+# database or a cache. For examples, see the Awesome Compose repository:
+# https://github.com/docker/awesome-compose
+services:
+  slack:
+    build:
+      context: ./slack
+      platforms:
+        - "linux/amd64"
+    environment:
+      NODE_ENV: production
+    ports:
+      - 3000:3000
+  logfile:
+    build:
+      context: ./files
+      platforms:
+        - "linux/amd64"
+    environment:
+      NODE_ENV: production
+    ports:
+      - 3010:3000