Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling subject field in auditlist resolved #969

Merged
merged 5 commits into from
Jan 2, 2024
Merged

handling subject field in auditlist resolved #969

merged 5 commits into from
Jan 2, 2024

Conversation

TahaKhanAbdalli
Copy link
Collaborator

fixes #950

@IanMayo IanMayo temporarily deployed to rco-review-pr-969 December 22, 2023 11:47 Inactive
@IanMayo IanMayo temporarily deployed to rco-review-pr-969 December 22, 2023 14:00 Inactive
@IanMayo
Copy link
Contributor

IanMayo commented Dec 22, 2023

Two things to tidy, please @TahaKhanAbdalli

  1. Subject and data aren't all that clear now that we have different resource types. Could we please rename data to Subject and Subject to Object (that's the correct interpretation of subject and object in this context.
  2. Could we put the new Subject and Object filters at the end of the list of available filters please?

@IanMayo IanMayo temporarily deployed to rco-review-pr-969 December 26, 2023 06:08 Inactive
@IanMayo IanMayo temporarily deployed to rco-review-pr-969 January 2, 2024 11:56 Inactive
@IanMayo IanMayo temporarily deployed to rco-review-pr-969 January 2, 2024 13:16 Inactive
@IanMayo IanMayo temporarily deployed to rco-review-pr-969 January 2, 2024 13:19 Inactive
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IanMayo IanMayo merged commit efff9ef into main Jan 2, 2024
2 checks passed
@IanMayo IanMayo deleted the 950_auditlist_handling_subject_field branch January 2, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMayo IanMayo IanMayo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit List - handling of Subject field
2 participants
@TahaKhanAbdalli @IanMayo