Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

966 - unique value for new mediaType id #974

Merged
merged 2 commits into from
Jan 3, 2024
Merged

966 - unique value for new mediaType id #974

merged 2 commits into from
Jan 3, 2024

Conversation

IanMayo
Copy link
Contributor

@IanMayo IanMayo commented Jan 2, 2024

Fixes #966

@IanMayo IanMayo temporarily deployed to rco-review-pr-974 January 2, 2024 15:50 Inactive
@IanMayo IanMayo changed the title use maximum value of id, rather than current number of rows 966 - unique value for new mediaType id Jan 2, 2024
@IanMayo
Copy link
Contributor Author

IanMayo commented Jan 2, 2024

Could you check this please @TahaKhanAbdalli - feel free to tidy the code, if necessary.

@IanMayo IanMayo temporarily deployed to rco-review-pr-974 January 3, 2024 12:13 Inactive
@IanMayo IanMayo requested a deployment to rco-review-pr-974 January 3, 2024 12:13 Abandoned
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IanMayo IanMayo requested a deployment to rco-review-pr-974 January 3, 2024 12:13 Abandoned
@IanMayo
Copy link
Contributor Author

IanMayo commented Jan 3, 2024

Great, thanks @TahaKhanAbdalli

@IanMayo IanMayo merged commit 2b01f54 into main Jan 3, 2024
3 checks passed
@IanMayo IanMayo deleted the 966_new_media_type branch January 3, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TahaKhanAbdalli TahaKhanAbdalli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create new MediaType
2 participants
@IanMayo @TahaKhanAbdalli