resource filter in audit list issue resolved #975
Conversation
src/resources/audit/AuditList.tsx
Outdated
| @@ -43,6 +43,21 @@ const SecurityRelatedFilter = ({ | |||
|
|
|||
| return <Chip sx={{ marginBottom: 1 }} label={label} /> | |||
| } | |||
| const availableResources = [ | |||
There was a problem hiding this comment.
@TahaKhanAbdalli - don't we have constants for these string values?
src/resources/audit/AuditList.tsx
Outdated
| 'destruction', | ||
| 'vaultLocation', | ||
| 'dispatch', | ||
| 'project', |
There was a problem hiding this comment.
Aah, we cosmetically rename project using the config data.
I think this requires this change:
- array contains pairs of elements - the resource name and the cosmetically displayed label. For this, we'll use the config value for
projectand presentvaultLocationasvault location(same with mediaType). - when we render values for the
resourcecolumn, we should display this cosmetic label, not the rawresourcevalue.
There was a problem hiding this comment.
Working on it.
src/resources/audit/config.tsx
Outdated
| [constants.R_DESTRUCTION]: 'Destruction', | ||
| [constants.R_VAULT_LOCATION]: 'Vault Location', | ||
| [constants.R_DISPATCH]: 'Dispatch', | ||
| [constants.R_PROJECTS]: 'Project', |
There was a problem hiding this comment.
the value of Project needs to come from the config-file, please @TahaKhanAbdalli
There was a problem hiding this comment.
got it.
I was thinking to add config based on audit and other files but never-mind. let me add them to the constants file.
There was a problem hiding this comment.
But note: the resource used in the filter needs to be project (since that's the resource/table name), but the displayed label will come from the ConfigData (it's Projekt in our mock dataset)
There was a problem hiding this comment.
Should I turn project to Projekt into the resource filter?
|
Just one more bit - taking the |
src/resources/audit/AuditList.tsx
Outdated
| source='resource' | ||
| label='Resource' | ||
| render={(record) => ( | ||
| <span> |
There was a problem hiding this comment.
@TahaKhanAbdalli - have a linter warning on the next line.
Is it worth refactoring it into an arrow function, where we can be a bit more verbose?
There was a problem hiding this comment.
Let me check.
|
fixes #951