Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live items asset report fails with project filter issue resolved #982

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

TahaKhanAbdalli
Copy link
Collaborator

fixes #957

@IanMayo IanMayo temporarily deployed to rco-review-pr-982 January 9, 2024 15:32 Inactive
@IanMayo
Copy link
Contributor

IanMayo commented Jan 9, 2024

Software working, but one minor issue. If the user has provided a filter for Project, we need to cosmetically change the label to the one from configData:
image

So, in our sample data it will show Projekt: rather than Project:.

Copy link
Contributor

@IanMayo IanMayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@IanMayo IanMayo temporarily deployed to rco-review-pr-982 January 10, 2024 09:05 Inactive
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IanMayo IanMayo merged commit 4a079dc into main Jan 10, 2024
3 checks passed
@IanMayo IanMayo deleted the 957_live_items_asset_report_fails_with_projekt_filter branch January 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live Items - Asset Report fails with Projekt filter
2 participants