Skip to content

Fix init state and reservoir/lake state 1d-2d local inertial model #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vers-w opened this issue May 22, 2025 · 0 comments · Fixed by #623
Closed

Fix init state and reservoir/lake state 1d-2d local inertial model #622

vers-w opened this issue May 22, 2025 · 0 comments · Fixed by #623
Assignees

Comments

@vers-w
Copy link
Collaborator

vers-w commented May 22, 2025

Setting the state of the local inertial model for land routing is not working, broken during refactoring of the code for v1.0.

Improved the accuracy of reservoir or lake state after initialization with a warm state by re-ordering computations of 1d-2d local inertial model. The inflow from land to a reservoir or lake was updated during the local inertial overland flow routing (final computation during each internal time step of the 1d-2d local inertial model). This results in small inflow deviations when starting with a warm state as the inflow from land to a reservoir or lake is not yet updated while a reservoir or lake is updated as part of the river routing. Order of computations is now: 1) overland flow routing, 2) reservoir or lake inflow and 3) river routing.

@vers-w vers-w self-assigned this May 22, 2025
@vers-w vers-w added the bug Something isn't working label May 22, 2025
@vers-w vers-w changed the title Fix init state and waterbody boundary condition local inertial model Fix init state and reservoir/lake state 1d-2d local inertial model May 26, 2025
@vers-w vers-w removed the bug Something isn't working label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant